Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4552702imu; Tue, 15 Jan 2019 01:54:17 -0800 (PST) X-Google-Smtp-Source: ALg8bN7dwlPc43UZ2ZQK3BQKNzFpUB58Vfc3uHxfbbAzVhtDLECJrLSLyQzr3nt7ErldJRHYsToj X-Received: by 2002:a63:c24c:: with SMTP id l12mr3111550pgg.146.1547546057856; Tue, 15 Jan 2019 01:54:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547546057; cv=none; d=google.com; s=arc-20160816; b=gp/1kKVLOa3EPUJzaRRz1squtuH0scxdyakxiqXP+UVI0dKZLixudi49IXWSyjW8oi klIuwyACsMCd1eLwFJywKjAoR1/TGrPtVwmq8rIvodQOz1fbXXJu/gngfO1ne09hUsnv ytBi6ZQuRIeKGd+z+y8wopLKbfqzQRFer+cc5lzSVVBmi9VokldwyYkiUU8IwmC1IwWz NSdakJ1stVHaxPWGse7BwkJWFVoZaOSNK6M/16Hs3fEXilIEBy7wv+StLjVPPPzoxUnI xRuizYwhPp69AyusYcPasJdXZAvCfYOUo5IXNZGF6LYlrtIYZC8k/J+GVj1OFbakirOa iSoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=2wOlUfsd4CXEBmrAtnvxTsH/VZdq+SudKmMGgtkqA08=; b=tHFpGVZ3NQRHMktwE8fFBGJVwFsx9RaTzQ7SH0TxLypk+T+wthl3BXqYTMZcSqwrbg UoURIEKVkFim7S2SRkEFfEYFaLVAckvP4LEM7NNJNFEpK6W0pKX/M2iChLaq+tBwxDx6 Ny/23SbPsbkMKOK1sqeaDqwbsbyLxzi4ioK6J0dMl3tiNsGdPpnP1Azmo97dgpRpNUw4 84WIO/pI+7bKlOHgT8LJwhAe2N3FVag1Y1yRiHl6oeE/wmPFTRlaBYDBHnas0IdhNOcH IczBHnlkvPEWostp6o8WmkI58/D9zqR2sTVQT4atrxOzEPWdAkRxK0/dIxsf1/naeDxA wneg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si2824881pgr.252.2019.01.15.01.54.02; Tue, 15 Jan 2019 01:54:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728498AbfAOJlb (ORCPT + 99 others); Tue, 15 Jan 2019 04:41:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbfAOJlb (ORCPT ); Tue, 15 Jan 2019 04:41:31 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B75EC81F0F; Tue, 15 Jan 2019 09:41:30 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-83.pek2.redhat.com [10.72.12.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54FFB19C7E; Tue, 15 Jan 2019 09:41:19 +0000 (UTC) Subject: Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, akpm@linux-foundation.org, bhe@redhat.com, dyoung@redhat.com, k-hagio@ab.jp.nec.com, anderson@redhat.com, linux-doc@vger.kernel.org References: <20190110121944.6050-1-lijiang@redhat.com> <20190110121944.6050-2-lijiang@redhat.com> <20190111145650.GG4729@zn.tnic> <20190114091509.GC2773@zn.tnic> From: lijiang Message-ID: <718e6763-8606-1778-de41-c6bc9f9e8c92@redhat.com> Date: Tue, 15 Jan 2019 17:41:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190114091509.GC2773@zn.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 15 Jan 2019 09:41:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2019年01月14日 17:15, Borislav Petkov 写道: > On Mon, Jan 14, 2019 at 01:30:30PM +0800, lijiang wrote: >> I noticed that the checkpatch was coded in Perl. But i am not familiar with >> the Perl program language, that would be beyond my ability to do this, i have >> to learn the Perl program language step by step. :-) > > You could give it a try - it is not hard :-) > Thank you for encouraging me to do the things. > And there's no hurry for this, take your time. > OK. I would like to put this task in my queue. Once i have free time, i will work on this issue. >> Do you mean this one 'KERNEL_IMAGE_SIZE'? > > I mean, all those which are unused. Optimally, you should look at the > tools and see whether they're using those exports and if not, remove > them. But no hurry here too, take your time. > OK. I will check it again, But, basically they are used by Makedumpfile or Crash tools. > My final goal is to have this up-to-date documentation of what is > exported and what is used by user tools so that people can look at it > first before carelessly exporting yet another thing. > Agree. Thanks, Lianbo > Thx. >