Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4552913imu; Tue, 15 Jan 2019 01:54:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN6RrCsE4rwhlrqOjdzXlDG9JKUSj0dbldD1Cgj3WSEJRB/RZZOnzZFfTr16rliUpjH6aTDX X-Received: by 2002:a17:902:31a4:: with SMTP id x33mr3162400plb.41.1547546072753; Tue, 15 Jan 2019 01:54:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547546072; cv=none; d=google.com; s=arc-20160816; b=1JtgWdliTCc0jf1M6PYthNQsqwpaOOWjbKSBB8WbsDWoa8EsfWA7H9q41GYBPBv453 +ikT18ufDv64XjhoWqHaS2slOsBqoT1DUe/xjyQ73vEGFeScjUYrt7PzQmZzfkWjSS0o qRU/2zRjwvqhhG5cS2iOnTcleVFQ4rXcdp0uhDL6iso2Fxs4ZW8pqbQyQtrnFlBI2zJK Y9JrU9PuJv/SH4mU4XB/z8klXFA+bVFWeFJhf1D7MC9zEXY2CtcBgrrq/+hO1sNLShwE cGAMCX+lfK6dz36DHjDeT13MSRB4UH6kbVveIWSkrC/78AJrhcA+z4LqjRxR6fFk17Rs 10fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=irhXYh30F/KWOm1pYYdlsG7PopqwEMuj6bUiAySmrXc=; b=xG/NWVblNf1ZKeosiTana96Yh/MCJZY217Itc1XAABcbxAZztNob4E7v4yKkOVzvY2 wQSSCFIxxZhQ07KlzU6BYEJxyly8BXhs7JZN/b3OJXSwKjP1qCMoVspvc45wH63+D+YT DrsnrOq2b8cbfUMz3uHoXy9sgBkJzTy1QqY08s0miVSeI+5WsYyzYgZR2YQjkQW043kF YmrmGLhA0N3oh3JTgxoWZpDt6VexfYdI5SS2ymbQ2IUcXjli4Mu6rP+QijQjf7V0fo+W hZzgX49a7/4p0JwUnIR91KmHViyF2vTq37wZjxkvdVcv8vHCLWBlLqzK4vZpDVHqu6Ph SX6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si3023891pfg.233.2019.01.15.01.54.17; Tue, 15 Jan 2019 01:54:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728738AbfAOJqG (ORCPT + 99 others); Tue, 15 Jan 2019 04:46:06 -0500 Received: from terminus.zytor.com ([198.137.202.136]:52083 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbfAOJqF (ORCPT ); Tue, 15 Jan 2019 04:46:05 -0500 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x0F9js2h2461534 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 15 Jan 2019 01:45:54 -0800 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x0F9jsTD2461531; Tue, 15 Jan 2019 01:45:54 -0800 Date: Tue, 15 Jan 2019 01:45:54 -0800 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Mathieu Malaterre Message-ID: Cc: hpa@zytor.com, malat@debian.org, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de Reply-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, malat@debian.org, hpa@zytor.com In-Reply-To: <20190114203154.17125-1-malat@debian.org> References: <20190114203154.17125-1-malat@debian.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] genirq: Annotate implicit fall through Git-Commit-ID: 44133f7eaebec227d1381868d642e3c64023520f X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_DATE_IN_FUTURE_96_Q autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 44133f7eaebec227d1381868d642e3c64023520f Gitweb: https://git.kernel.org/tip/44133f7eaebec227d1381868d642e3c64023520f Author: Mathieu Malaterre AuthorDate: Mon, 14 Jan 2019 21:31:54 +0100 Committer: Thomas Gleixner CommitDate: Tue, 15 Jan 2019 10:40:34 +0100 genirq: Annotate implicit fall through There is a plan to build the kernel with -Wimplicit-fallthrough. The fallthrough in __irq_set_trigger() lacks an annotation. Add it. Signed-off-by: Mathieu Malaterre Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/20190114203154.17125-1-malat@debian.org --- kernel/irq/manage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index a4888ce4667a..1ca39dc4538d 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -723,6 +723,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned long flags) case IRQ_SET_MASK_OK_DONE: irqd_clear(&desc->irq_data, IRQD_TRIGGER_MASK); irqd_set(&desc->irq_data, flags); + /* fall through */ case IRQ_SET_MASK_OK_NOCOPY: flags = irqd_get_trigger_type(&desc->irq_data);