Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 15 Jan 2019 01:46:30 -0800
From:   tip-bot for Mathieu Malaterre <tipbot@zytor.com>
Message-ID: <tip-01cdfa912f1004c463586f52f1dfcbec1274b1f2@git.kernel.org>
Cc:     hpa@zytor.com, linux-kernel@vger.kernel.org, malat@debian.org,
        mingo@kernel.org, tglx@linutronix.de
Reply-To: hpa@zytor.com, linux-kernel@vger.kernel.org, malat@debian.org,
          mingo@kernel.org, tglx@linutronix.de
In-Reply-To: <20190114203633.18557-1-malat@debian.org>
References: <20190114203633.18557-1-malat@debian.org>
To:     linux-tip-commits@vger.kernel.org
Subject: [tip:irq/core] genirq: Correctly annotate implicit fall through
Git-Commit-ID: 01cdfa912f1004c463586f52f1dfcbec1274b1f2
Robot-ID: <tip-bot.git.kernel.org>
Robot-Unsubscribe: Contact <mailto:hpa@kernel.org> to get blacklisted from
 these emails
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Commit-ID:  01cdfa912f1004c463586f52f1dfcbec1274b1f2
Gitweb:     https://git.kernel.org/tip/01cdfa912f1004c463586f52f1dfcbec1274b1f2
Author:     Mathieu Malaterre <malat@debian.org>
AuthorDate: Mon, 14 Jan 2019 21:36:33 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 15 Jan 2019 10:40:53 +0100

genirq: Correctly annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough. The
fallthrough in __handle_irq_event_percpu() has a fallthrough annotation
which is followed by an additional comment and is not recognized by GCC.

Separate the 'fall through' and the rest of the comment with a dash so the
regular expression used by GCC matches.

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190114203633.18557-1-malat@debian.org
---
 kernel/irq/handle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 38554bc35375..6df5ddfdb0f8 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags
 
 			__irq_wake_thread(desc, action);
 
-			/* Fall through to add to randomness */
+			/* Fall through - to add to randomness */
 		case IRQ_HANDLED:
 			*flags |= action->flags;
 			break;