Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 0/8] nvmem: Various small fixes and improvements
To:     Alban Bedel <albeu@free.fr>
Cc:     linux-kernel@vger.kernel.org
References: <20190106192820.12558-1-albeu@free.fr>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <de2ef429-0e9a-0104-93d4-502836fbe0b9@linaro.org>
Date:   Tue, 15 Jan 2019 12:40:37 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190106192820.12558-1-albeu@free.fr>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06/01/2019 19:28, Alban Bedel wrote:
> Hi,
> 
> this series is mostly small bug fixes, but also add a new API
> to make things simpler in drivers that need to request an optional cell.
> 
> Alban Bedel (8):
>    nvmem: core: Set the provider read-only when no write callback is
>      given
>    nvmem: core: Fix of_nvmem_cell_get() for optional cells
>    nvmem: Add nvmem_cell_get_optional and devm_nvmem_cell_get_optional
>    nvmem: core: Fix cell lookup when no cell is found
>    nvmem: core: Properly handle connection ID in of_nvmem_device_get()
>    nvmem: core: Always reference the device returned by
>      nvmem_device_get()
>    nvmem: core: Fix device reference leak
>    nvmem: core: Avoid useless iterations in nvmem_cell_get_from_lookup()
> 
>   drivers/nvmem/core.c           | 86 +++++++++++++++++++++++++++-------
>   include/linux/nvmem-consumer.h | 16 +++++++
>   2 files changed, 86 insertions(+), 16 deletions(-)
> 

Thanks Alban for the work!
Most of the patches look good to me except nvmem_cell_get_optional()!

Will send out comments on that patch separately!

-srini