Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190110111535.11235-1-anders.roxell@linaro.org> <CAOMZO5DGxXBCFbLgqeophv_Jw2nO5wiPXJXuth6CPEfSr9f9=w@mail.gmail.com>
In-Reply-To: <CAOMZO5DGxXBCFbLgqeophv_Jw2nO5wiPXJXuth6CPEfSr9f9=w@mail.gmail.com>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Tue, 15 Jan 2019 15:14:12 +0100
Message-ID: <CADYN=9KOqZXiFYvxWED-f_sJS6G-CqY2pPUYohGuP9Pa6VGUZQ@mail.gmail.com>
Subject: Re: [PATCH] dma: ixm-dma: fix warning comparison of distinct pointer types
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Vinod <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>,
        dmaengine@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 14 Jan 2019 at 22:24, Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Anders,
>
> On Thu, Jan 10, 2019 at 9:15 AM Anders Roxell <anders.roxell@linaro.org> =
wrote:
> >
> > The warning got introduced by commit 930507c18304 ("arm64: add basic
> > Kconfig symbols for i.MX8"). Since it got enabled for arm64. The warnin=
g
> > haven't been seen before since size_t was 'unsigned int' when built on
> > arm32.
> >
> > ../drivers/dma/imx-dma.c: In function =E2=80=98imxdma_sg_next=E2=80=99:
> > ../include/linux/kernel.h:846:29: warning: comparison of distinct point=
er types lacks a cast
> >    (!!(sizeof((typeof(x) *)1 =3D=3D (typeof(y) *)1)))
> >                              ^~
> > ../include/linux/kernel.h:860:4: note: in expansion of macro =E2=80=98_=
_typecheck=E2=80=99
> >    (__typecheck(x, y) && __no_side_effects(x, y))
> >     ^~~~~~~~~~~
> > ../include/linux/kernel.h:870:24: note: in expansion of macro =E2=80=98=
__safe_cmp=E2=80=99
> >   __builtin_choose_expr(__safe_cmp(x, y), \
> >                         ^~~~~~~~~~
> > ../include/linux/kernel.h:879:19: note: in expansion of macro =E2=80=98=
__careful_cmp=E2=80=99
> >  #define min(x, y) __careful_cmp(x, y, <)
> >                    ^~~~~~~~~~~~~
> > ../drivers/dma/imx-dma.c:288:8: note: in expansion of macro =E2=80=98mi=
n=E2=80=99
> >   now =3D min(d->len, sg_dma_len(sg));
> >         ^~~
> >
> > Rework so that we use min_t and pass in the size_t that returns the
> > minimum of two values, using the specified type.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> There is a typo in the Subject: s/ixm/imx/ and the prefix should be
> dmaengine instead:
>
> dmaengine: imx-dma: fix warning comparison of distinct pointer types
>
> With that fixed:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

OK, thanks Fabio.

Dan, do you want me to resend the patch with an updated shortlog or will
you do that when you apply the patch?

Cheers,
Anders