Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4959507imu; Tue, 15 Jan 2019 08:48:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN756EfwhhFCuc+5+0WfyE0C6LgCbPkjZZEJC4vOreT1GgONpwf9nq/q5Sr5CychJSPKxfMr X-Received: by 2002:a65:4683:: with SMTP id h3mr4377550pgr.225.1547570900793; Tue, 15 Jan 2019 08:48:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547570900; cv=none; d=google.com; s=arc-20160816; b=n9yYRSWX0xoe7BSgeJXEpIW1jMKUsSSomuUBZlOa44Rdh1g12QJnkhNgpvmyrf7wkv 8hx+DOjn/bWuVuJiRPy9GnG+kWBgOb3EJgSpm3US+3T8eqWGcWdMlghbX9ezLr40W3w5 V+ODFhlcleIq72Eth9mIILml/8P6pWeZPTm4Nrtu8SV/NFxwRamhGlyXgSFoMFeg1LFg RCBIcTQHX388AjV0cIsxeWqVPkmqg4le4e5ZRM8c1NYiwjiWFrWJoOA9iGzFjj2V/ZDn h0qoP5qw5rQPZRoyN0aWRCu6wH9zUVxLAswYPdxRoBtp50MoZXSuR7/keQV96lNIv9xg su2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=opK8COkigmz0NFnchVnzN0WwfNsAGHZZ5MfSbVwO76c=; b=QN5TElxU3eGPnBsLFQ08gSOLbmVPONx5gSbK7B+CAgzma1ilVsxps9QtD9dTV2Hcbf H5sHchNlqjaqZ5boZOOA/vK4MgEaWpwOjapR6scV5Ta4SaVzsq+cq+VMKiGvaIEaxvB4 ubtkSpBQc6G06az8CD3EeI/V4WAngNCCrjjmLhs/BwT+txpyDvyHZZhvQS73DyaD8SWM 4KCRabdamBV0OZuZEjbPLYn9CiL6GIsqK82QsK2rVkohMsVece6jIFHaJKO5pM0umnQz v3cwhV88XP487rkyqO0vtzIV37WnhlAQ+6Z9xjJaCgW35ZdKAL0HrcI9EggMH9/2JJrJ tJ9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XJeTUcaD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si382431plk.296.2019.01.15.08.48.02; Tue, 15 Jan 2019 08:48:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XJeTUcaD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731350AbfAOP5c (ORCPT + 99 others); Tue, 15 Jan 2019 10:57:32 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:37954 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730211AbfAOP5c (ORCPT ); Tue, 15 Jan 2019 10:57:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=opK8COkigmz0NFnchVnzN0WwfNsAGHZZ5MfSbVwO76c=; b=XJeTUcaDv53vxbK6/XI/K53aj rPa/x0fxDelXpyj8dYNzMiiYetpN3e27R5ycDbJytRkCC4I/WMHdjrL7ca25BRro7lBuRQ+mOPaT0 +RzHc6TIaiQWQxOFUwH6yYwb2EVtdzJxbxLOki4zttTkAo/SjyiOPsGEEjsI5tnh2R8MYfWqkRYZm Ft/BIhfUNaOXMne64m4/JWO5LlmiQyIFzB3D4cMQdBGFulXw8h/sqhARvk+Tt/eCkFx+ruDyBUSm+ LygjWzg2qSx5zeLPSR5RCNOABMZrclSKFe+rKhQa3/l2YEb9sbNq/Qn6p+FbFYItr/m7j5UHU9e4M YlCsJ1z/Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjR5j-0005dc-Gb; Tue, 15 Jan 2019 15:57:27 +0000 Date: Tue, 15 Jan 2019 07:57:27 -0800 From: Christoph Hellwig To: Anup Patel Cc: Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , Jason Cooper , Marc Zyngier , Christoph Hellwig , Atish Patra , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/5] irqchip: sifive-plic: Implement irq_set_affinity() for SMP host Message-ID: <20190115155727.GD13095@infradead.org> References: <20181227111821.80908-1-anup@brainfault.org> <20181227111821.80908-6-anup@brainfault.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181227111821.80908-6-anup@brainfault.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (!force) > + cpu = cpumask_any_and(mask_val, cpu_online_mask); > + else > + cpu = cpumask_first(mask_val); Any reason for the inverted test? Otherwise this looks fine to me: Reviewed-by: Christoph Hellwig