Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4966880imu; Tue, 15 Jan 2019 08:55:42 -0800 (PST) X-Google-Smtp-Source: ALg8bN7pmVSejc9t95h73YU0A9BFsy3MdPGvuwE5M7B416zm6oAtDIDUqXanFdWQq7q8A5pzvJUN X-Received: by 2002:a62:b9a:: with SMTP id 26mr5011621pfl.196.1547571341698; Tue, 15 Jan 2019 08:55:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547571341; cv=none; d=google.com; s=arc-20160816; b=LcOQkPNcban+vYqxnD6qKOy1VybTCdk1djxZpA3b22Hdj79VmnCQ8fUcizWtAxt8/E ZkNwH6ycnQijiGIwPJaxONKeEpbgoqm7zOPYq5jlqWrGpjKhrxofDqKd9M55tbKwOM7m QCT0aRmto9VPlE7rBTrlOhiaXzPoMZBSIhtGoL9xnoib5FLGZWgW8qE9f9rL4xSUoqmd kMXW2T+fCanQgaCKiW/Yacz+a8chm7zyoeVlkDvV404jd+QyRr71Ww78yocPyVfMx4dz Yig/zHa1lD6+LhyYLs3VyWJHEFQryrkUEUsZ22oeF4AxXpuJsw8HpvP9gCfewuQEgjXd iwOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=P17uqvALHsMUsRlhBsMdBNVWLSGnEoWyFVmVvv3NUzA=; b=ouU1fN7qmVsmnBC2dn3Sw/oEX87Rq9hi+mcP2f7ualAfSZK8YouqCzMr7d3WuP2KCr YeLWyKUn+AoPE14S2TBsPdltVx95iR/F0X9Xx87Rm/e+nWO304V5xmHfEgP7N10A8vdQ MFs0VHRAL0jZjAVG2SecSKJuBnMFDb+f/m8szCWETSN8PH7doKy3GkePxOesHxXZQCu+ cSolNEtk7oBDy1R+zk8yIPcoEME/A+2bJCcHToe6i06Gtfycp2zeGZ5toYEguvmh++U5 /gA3F908r7i5EycRDEC2TTTCik9m8MsiKeX9fLpdybbgbANDK5jW/jl1MgiI7eBTbmIe YyIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jH1vqpnH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24si3592756pgj.582.2019.01.15.08.55.26; Tue, 15 Jan 2019 08:55:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jH1vqpnH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730654AbfAOPNU (ORCPT + 99 others); Tue, 15 Jan 2019 10:13:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:41972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728772AbfAOPNU (ORCPT ); Tue, 15 Jan 2019 10:13:20 -0500 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F058D204FD; Tue, 15 Jan 2019 15:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547565199; bh=Kn8ZXTa5Nz7EX2NWpPLtlirqIVUmk5Nw2RgTFr9vVwA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jH1vqpnHRg+Cou1aDdC9bjQmWBVe5Hjtfd+7n1rwUQ3ATT6gw+TqONesIaqMomDMU 7wEiqx+cFbaHYZC1JMMjUTQ4ObAi9fPeCqiwfxLDKsn89yVuFsjggEbyzdGg1K7sQN mHfl4K+rhi2g+r2B3nw7Lv32OOFrfA0Tq6ji15Cw= Date: Tue, 15 Jan 2019 23:12:52 +0800 From: Shawn Guo To: Stephen Rothwell Cc: Leonard Crestez , dl-linux-imx , "linux-kernel@vger.kernel.org" , "linux@armlinux.org.uk" , Fabio Estevam , "linux-next@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Anson Huang , "kernel@pengutronix.de" , "s.hauer@pengutronix.de" Subject: Re: [PATCH V2] ARM: imx: add i.MX7ULP cpuidle support Message-ID: <20190115151250.GC13895@dragon> References: <1547185955-2395-1-git-send-email-Anson.Huang@nxp.com> <20190114005600.GN11426@dragon> <20190116001043.69529b90@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190116001043.69529b90@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 12:10:43AM +1100, Stephen Rothwell wrote: > Hi Leonard, > > On Tue, 15 Jan 2019 12:30:23 +0000 Leonard Crestez wrote: > > > > On 1/14/19 2:56 AM, Shawn Guo wrote: > > > On Fri, Jan 11, 2019 at 05:57:30AM +0000, Anson Huang wrote: > > > > This patch adds cpuidle support for i.MX7ULP, 3 cpuidle > > > > states supported as below: > > > > > > > > 1. WFI, just ARM wfi; > > > > 2. WAIT mode, mapped to SoC's partial stop mode #3; > > > > 3. STOP mode, mapped to SoC's partial stop mode #1. > > > > > > > > In WAIT mode, system clock and bus clock will be enabled; > > > > In STOP mode, system clock and bus clock will be disabled. > > > > > > > > Signed-off-by: Anson Huang > > > > > > Applied, thanks. > > > > > > > Hello, > > > > I'm not sure if anyone else already noticed but it seems the > > arch/arm/mach-imx/cpuidle-imx7ulp.c file was dropped? > > > > It's not in your tree: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/soc&id=cf2d2d392906f5603cf0d0f3630f6386babf7e4b > > > > This causes build failures in next-20190115 with imx_v6_v7_defconfig. > > That file does not exist in Linus' tree either. And there are no > commits in linux-next that add it. Sorry. That's my fault. The patch doesn't apply to my tree and I had to use 'patch' command. However, I forgot to add this new cpuidle-imx7ulp.c file. Just fixed it. Shawn