Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4969128imu; Tue, 15 Jan 2019 08:58:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN641V6KS8grfUEtJB2jOY+/XATxFgO1aAtT/JCdpN223EZw+fxaB6rT+7BZJZoqVbLK6kXl X-Received: by 2002:a17:902:b60a:: with SMTP id b10mr4781500pls.303.1547571485821; Tue, 15 Jan 2019 08:58:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547571485; cv=none; d=google.com; s=arc-20160816; b=eGSzlXKiQi//OCEUapVbWoRmWv8/zVARSCo6ESksd+TC0cg8gSEv/rm+4JlRXpxeFn NH+GV7a+s6ppBuPxxcYkIAlGCrG5hddzD3V6R+rfhqBY4YmNASL4MzTocfiwWAgo6Hpi QGvByER+4Efh6u1IrbMEvaWNk7XUsYyhJmMwfQkEiSOg5l3lk6WLjPwZ0H5g+afY+6m1 0wR8csmNKCLK/J9tMXaOITG2/QYchhX0tpwgSQ2OGYLNFXTv9ndVor4Yv1zyavF+Kql4 fYEGxITIcWIRmzDyNqi814BPvj4xqNjqZnnBkTEEOuT5CpMQKSCPyBbYB3O+nPM411Ts RPKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=mMAcmVGfI/+FLT/nYUVlo+2ucUfCQz7BXv98yiIBZwc=; b=YhxRJj/QT/08YqqUsLyXl71qmBhovQagZfMTUq9po8gm/BJW8rVseQ4lfIJVVUwpjx 513Ja12ggyvWxswcjeLEJT2Bo8bz/HdCEx+/MS5mw/tRI7LDNwdY6jMwe60AqVWBxH1k fRQLrHgZ1Hy7fv6cbqnis4gYqR3HNlHLf9ueczEHrjl85CNrcNcmcUZuxIABCDftu0du gfTNFpZGr9AmdB8TPrKKc7NmK9JMhGPgZiV3Gkl6jrJX/kQqca2GxCMF0CvKY8rQrBLF tNhxEMlk3MuRfzhaTo3l9TsYA8JTdRCrLHChuktktFwnOpHTqQb5ycP5zlo39vDM5meS x/rQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u184si3585244pgd.262.2019.01.15.08.57.47; Tue, 15 Jan 2019 08:58:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731210AbfAOPxR (ORCPT + 99 others); Tue, 15 Jan 2019 10:53:17 -0500 Received: from mail-sh.amlogic.com ([58.32.228.43]:38074 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727247AbfAOPxR (ORCPT ); Tue, 15 Jan 2019 10:53:17 -0500 Received: from localhost.localdomain (10.18.11.217) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server id 15.1.1591.10; Tue, 15 Jan 2019 23:38:54 +0800 From: Jianxin Pan To: Boris Brezillon , CC: Jianxin Pan , David Woodhouse , Miquel Raynal , Brian Norris , Marek Vasut , Richard Weinberger , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Carlo Caione , Kevin Hilman , Rob Herring , Liang Yang , Jian Hu , Hanjie Lin , Victor Wan , , , , Subject: [PATCH v9 0/2] mtd: rawnand: meson: add Amlogic NAND driver support Date: Tue, 15 Jan 2019 23:38:02 +0800 Message-ID: <1547566684-57472-1-git-send-email-jianxin.pan@amlogic.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.18.11.217] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These two patches try to add initial NAND driver support for Amlogic Meson SoCs, current it has been tested on GXL(p212) and AXG(s400) platform. Changes since V8 at [9] - fix build failre at object_is_on_stack - update Kconfig as Martin's suggested Changes since V7 at [8] - fix bitflips checking for blank pages - trace the latest commit with nand/next branch - checking the return of meson_nand_op_get_dma_safe_*input/output*_buf - add .detach_chip for free meson_nand.data_buf/info_buf Changes since V6 at [7] - use timings->tBERS_max as the maximum time out, delete NFC_CMD_RB_TIMEOUT - fix nand_rw_cmd and support small block flash and which row address less than 3 - fix coding style - replace readl/writel_* with readl/writel_relaxed* - delete ECC_SET_PROTECTED_OOB_BYTE and ECC_GET_PROTECTED_OOB_BYTE - implement dma access for read_buf and write_buf, more efficient. - delete waiting dma finish in write process and let NAND_CMD_PAGEPROG and RB command go on queuing - add waiting the completed flag of last ecc page be set, for more strict Changes since v5 at [6]: - use instr->delay_ns in exec_op() to caculate the delay cycle - delete struct meson_nfc_info_format and use macros instead - delete "is_scramble" in struct meson_nfc_nand_chip - add WARN_ON_ONCE() for chip > MAX_CE_NUM - drop param *mtd* or struct *nfc* if param *nand exist - substitute set_data_oob and get_data_oob for prase_data_oob and format_data_oob - split timings caculating and setting timings - move info_buf and data_buf to struct meson_nfc_nand_chip Changes since v4 at [5]: - remove the initial default divider(CLK_DIV_MASK) in meson_nfc_clk_init() - dt-bindings: remove staus, add "rx" and "tx" clock, and node rename Changes since v3 at [4]: - remove partition table and some used props from dt-bindings Changes since v2 at [3]: - remove some hardcode time value, like twb - use dev wait R/B instead of nand_soft_waitrdy - implement nfc ecc init by ecc helper - rework nfc buffer init to register the maximun buffer when several chips - free nfc buffer when error and cleanup - add variable to teack all the already assigned CS lines - fix mtd->name use the first cs line only - remove dt "nand-enable-scrambler" and use NAND_NEED_SCRAMBLING instead. - move setuping ECC fileds after the identification phase - use nand_scan() and attach_chip() - check one event to return IRQ_NONE - delete cast when of_device_get_match_data - use nand_controller_init() helper - remove nfc driver complains when calling devm_ioremap_resource - clear irqs before setting up irq handler Changes since v1 at [1]: - adopt property amlogic,nand-enable-scrambler - thanks Martin - drop nand pins in DT - convert clk access to emmc clkc model - fix regiser field definition alignment - drop nand-user-mode - parse cs id from DT - rework n2m, m2n function - explain why insert two "IDLE" command - implement exec_op() - drop meson_nfc_get_nand_chip_dts() - release resource once error occur in meson_nfc_nand_chips_init(), - call nand_cleanup(nand) once mtd_device_register fail Items not addressed ( or confirmed ) in this version: - convert to ECC conf helper() - convert to dma coherent API - how to construct mtd->name [1] https://lkml.kernel.org/r/20180613161314.14894-1-yixun.lan@amlogic.com [2] https://lkml.kernel.org/r/20180712211244.11428-1-yixun.lan@amlogic.com [3] https://lkml.kernel.org/r/20180719094612.5833-1-yixun.lan@amlogic.com [4] https://lkml.kernel.org/r/1536317831-58056-1-git-send-email-jianxin.pan@amlogic.com/ [5] https://lore.kernel.org/r/1537433449-65213-2-git-send-email-jianxin.pan@amlogic.com/ [6] https://lore.kernel.org/r/1539839345-14021-1-git-send-email-jianxin.pan@amlogic.com [7] https://lore.kernel.org/r/1541090542-19618-1-git-send-email-jianxin.pan@amlogic.com [8] http://lkml.kernel.org/r/1542386439-30166-1-git-send-email-jianxin.pan@amlogic.com [9] http://lkml.kernel.org/r/1544973463-59523-1-git-send-email-jianxin.pan@amlogic.com Liang Yang (2): dt-bindings: nand: meson: add Amlogic NAND controller driver mtd: rawnand: meson: add support for Amlogic NAND flash controller .../devicetree/bindings/mtd/amlogic,meson-nand.txt | 60 + drivers/mtd/nand/raw/Kconfig | 8 + drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/meson_nand.c | 1468 ++++++++++++++++++++ 4 files changed, 1537 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt create mode 100644 drivers/mtd/nand/raw/meson_nand.c -- 1.9.1