Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4998323imu; Tue, 15 Jan 2019 09:23:07 -0800 (PST) X-Google-Smtp-Source: ALg8bN4GGkC/uy+SCklrdcLJXQ479IkXOjxAFTqG4JpcbcjZ0/4IAPDFPECwOjp19WBrQpv4ADLh X-Received: by 2002:a62:1d4c:: with SMTP id d73mr5166625pfd.90.1547572987667; Tue, 15 Jan 2019 09:23:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547572987; cv=none; d=google.com; s=arc-20160816; b=AQmFPekqxwvSJZeEet9kVp859Aq6JwNDx41rTLYNL5bPZEib0nrcMNyV5DLiHsqoCC JYiCs6uVfwH/Soe9WE+W1HvlhNyXFpIqPk84XyuJ1Zy3w0oi1G2CwOFRegZyYm8phtyG XgPqKl2LMu7/wj8poH59quXGuSqAvQSswu4XIQG1ghwr4+MolopVyI0nP9CJ3SZEZUyj AGhS3L/NbICm81sdrSGaP+OgA5PVTeo3nU1aDgX3xmYj3d2TThlDHbJOLgy6p1nn/BmH AXu9KabB2o2rxPJUFdZtBJJHrw86Vx2l/YCj4V0VHmxEZHF8XTEmSmyecc6CHWFfIls5 bjFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wBET1aOv4IRUslJ37ilGgnCFNrhFE/B+fe4p7JS23OY=; b=XE2sYVXgHJurAW+KPgE6WTbz4X1BosWbMoUrcLzRnFdbdm6ML078DDMcptChJY6rbG QMWt7eBLxJD+hYK7ei/vAnY4kfbm0ZhhF0a9TbJHN8YD62UZ50wYOk9G2Xu72pF/4pqg ZIxYfBv38+IQwVICGI+ccSntSZ26OBL5srQhtJrJVmUqRYxHLd7Pyo/wfODEtxDRjOP7 iOPsFtG78I07StkZxocP3AMb+eFD7dOMTftuev1A5QYw20dmevB91JbH3J4qptmhF/1i ThRp3XG/D1gOz1pGfEj4eO/k1qVD0lt82oQf+BEdgl7TB+D2GZsBncISptI3xdr8xGOy ZLaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OoczqLiW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 144si3779230pga.322.2019.01.15.09.22.48; Tue, 15 Jan 2019 09:23:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OoczqLiW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730277AbfAOOFP (ORCPT + 99 others); Tue, 15 Jan 2019 09:05:15 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:43662 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729370AbfAOOFO (ORCPT ); Tue, 15 Jan 2019 09:05:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=wBET1aOv4IRUslJ37ilGgnCFNrhFE/B+fe4p7JS23OY=; b=OoczqLiWbU00wxoHLeQm525I2KjClZq5nMUhuDvLF+261Kkc/HM0ilMA3D5Ns+mIaCjToYa3QqoJoaxxe0RKzpxMxuFUlyRLrB8vW+89EfvAQJ7lkSI8sxhbb/BeJ3lmhSDNxhjiAgsLTWQL9qanSNS12ORjcYlzRd696/qz28E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gjPL3-0005n9-9Q; Tue, 15 Jan 2019 15:05:09 +0100 Date: Tue, 15 Jan 2019 15:05:09 +0100 From: Andrew Lunn To: Camelia Groza Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net, oss@buserror.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: phy driver features are mandatory Message-ID: <20190115140509.GH19687@lunn.ch> References: <1547555719-13541-1-git-send-email-camelia.groza@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547555719-13541-1-git-send-email-camelia.groza@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 02:35:19PM +0200, Camelia Groza wrote: > Since phy driver features became a link_mode bitmap, phy drivers that > don't have a list of features configured will cause the kernel to crash > when probed. > > Prevent the phy driver from registering if the features field is missing. > > Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap") > Reported-by: Scott Wood > Signed-off-by: Camelia Groza Reviewed-by: Andrew Lunn Andrew