Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5189721imu; Tue, 15 Jan 2019 12:51:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN6+NdzRAnfAvt+uYffhQn11jGizWPt6Vg2OUZNpES9Lj6an/JMIZQmKQm2BolMQKRxDC9xw X-Received: by 2002:a63:f901:: with SMTP id h1mr5539813pgi.154.1547585503991; Tue, 15 Jan 2019 12:51:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547585503; cv=none; d=google.com; s=arc-20160816; b=WqbDYdZqV4TQttZebxm5oLH2LvgaRhD33oVzYJnCj8+RnPRS3Mczp7dIEKe+qZjkTE qYfUKLZ51L+8vrKAL3/UKkwtbz5a6Rb5iagkuZvt6xwRoxYQhU885jjko1Ldx9IyTO88 ZNWbcmpF+HK3qxWlXw/JIeC71DU7K0Z8VI/Vg1uZBPsU4HoPqyORoAdmUxBzOYpJTa3P 7yjUgxC8ynQaZAvf14/LZGgdBuyW6rKMktwwLJIllk1r9UmK0TTVU05r6i1bcgRme4Lh YZ3xC6HmPXBI3Z+9JkulSePisjWpblXb7gLhWHMpylkDFq5+I4SeY0tWE66Mr7TOiRiI m6MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+u3qeG83u8Nt6kDbGVKHMde7PzvVMmTLI4q8IO+o5aI=; b=ItduZIJ7FhOwvJGTo4MhZVmVhS9kRiV61Y2+UUIJcoVnEvkZaAnfuYDrvwSQTI8Sul gOjJf+fEnZHN8ElLkF1LJv17Yn30W4L2AQwJM67peFQG/Io198dqXHjgRiRNiR2sr6UW yvkQH7FhFDSCIfORFZVVI3Jqh4fzXt0PUVxWdHwUC6E4LjB7/Gwde16Yl/BNKzKl8uyj B/b0jzQOexD0+2cu6tC9/yaUY1HuVjwWZgkXRbwfvlQcMPozI6uy6to0gMRwZJCoErvA k/z1+jcfysivK8DYT3H9ruI9BFz4var2zKSb8uSI0WUARuuM9CvN8sM9ikCnXqBKGPEd kl/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rQhbeepw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z31si4266157plb.402.2019.01.15.12.51.15; Tue, 15 Jan 2019 12:51:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rQhbeepw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732668AbfAOQks (ORCPT + 99 others); Tue, 15 Jan 2019 11:40:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:57240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730407AbfAOQkq (ORCPT ); Tue, 15 Jan 2019 11:40:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35F3C2054F; Tue, 15 Jan 2019 16:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547570445; bh=/rhcauA8CMyoUinUgVnPJWcbmQozRc9ZHXJrnaX8+HA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rQhbeepwOccRsWLILT34XDMZekj7XX0xAQbYr1H4IMKW+zG+v9wXm0buILrbtN26k 6r2ia7yRLZx7/d9Vw8u3VsgjEbEN40IZTqqtfZdPjpX2357ZwwfYWLvRu0r6CEBzqB BsAouQlo6r97nrfA7xd/1xTGztRHRH8RbCMb/Z/Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Theodore Tso , stable@kernel.org Subject: [PATCH 4.14 25/27] ext4: track writeback errors using the generic tracking infrastructure Date: Tue, 15 Jan 2019 17:36:14 +0100 Message-Id: <20190115154903.116456934@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190115154901.189747728@linuxfoundation.org> References: <20190115154901.189747728@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Theodore Ts'o commit 95cb67138746451cc84cf8e516e14989746e93b0 upstream. We already using mapping_set_error() in fs/ext4/page_io.c, so all we need to do is to use file_check_and_advance_wb_err() when handling fsync() requests in ext4_sync_file(). Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/fsync.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -164,6 +164,9 @@ int ext4_sync_file(struct file *file, lo ret = err; } out: + err = file_check_and_advance_wb_err(file); + if (ret == 0) + ret = err; trace_ext4_sync_file_exit(inode, ret); return ret; }