Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5256392imu; Tue, 15 Jan 2019 14:12:16 -0800 (PST) X-Google-Smtp-Source: ALg8bN7uRzivZ7ZL50BI9+TK7CGthiWtyxwrjVw8NXCS3En56Wm9cvKeEz2dlT8Sw8a24aLRhLry X-Received: by 2002:a63:4d0e:: with SMTP id a14mr5857661pgb.408.1547590336509; Tue, 15 Jan 2019 14:12:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547590336; cv=none; d=google.com; s=arc-20160816; b=GwScN+Hlln6aZktR5BZ1uPHIvLJjMgRzgE8LLh+/mIQm6HROgvFa5/LrhMAM2gxeh7 WIpsXDJepfnoZF4TentGDwi/RW6AtKqe7PoVpH0LquMI3F4hXwusdoliOAWXqhkR56qM SIfdURvNijUDNvTNAtlDU6fbOR1LeBUquwMXhKuFaoRn/VlBdmLhVY8JJ6HXOAepah6T tJsiqNdK3xF7GUNsUVTV3l/GN/aeTdXGle01CG20MT8JVXWTXxVbREymbNZWRXQ/a3Ob wpkSXSFpgNM42xQ7GH5/qBHRgBDKCYDUyjyjYXhZAJJRkEpwRLoGw4dvL1G2j+0XsIuL vNLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=P9nnLOP8Nw78c/JBVuNi00tPpVO4OSqTz58HrxicYlc=; b=Rt7EVP/0ndH0nzjyO0j5pugnKq1lSr0vuK1bYEd46h5OrO1vJbWwkyY/IDYvgXgYNE m6v+sKGGViO/KZMUOjvooYC1ifL5dTWJiFPsmtTQ01/rdEr87s+bodcF9CcoClRIEfYC /TQI4Zc6T/wWmHRPBGdncmOvq/HHTDfEsfn6XSTAqmQlq3RPfPbMH4UwPIB/R6nM2k21 4vooLusgG4WFvvCYSJasOLdN4pJAbAsfdd/RzMkHOinHT/rzIy05uzrHGfeJBY8Ya8uJ lQRl1c7X9EyJoVaWhzmUYftiXezmlHqtKQhGRKPrYxCUufKiMTOU6NgF90aL4CflBvBH eAWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13si4532592pln.368.2019.01.15.14.12.00; Tue, 15 Jan 2019 14:12:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730261AbfAOQws convert rfc822-to-8bit (ORCPT + 99 others); Tue, 15 Jan 2019 11:52:48 -0500 Received: from mail.bootlin.com ([62.4.15.54]:59329 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728856AbfAOQwr (ORCPT ); Tue, 15 Jan 2019 11:52:47 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 856E920A9B; Tue, 15 Jan 2019 17:52:45 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from xps13 (173.203.136.77.rev.sfr.net [77.136.203.173]) by mail.bootlin.com (Postfix) with ESMTPSA id 0F2BA207A3; Tue, 15 Jan 2019 17:52:34 +0100 (CET) Date: Tue, 15 Jan 2019 17:52:32 +0100 From: Miquel Raynal To: Jianxin Pan Cc: Boris Brezillon , , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Carlo Caione , Kevin Hilman , Rob Herring , Liang Yang , Jian Hu , Hanjie Lin , Victor Wan , , , , Subject: Re: [PATCH v9 0/2] mtd: rawnand: meson: add Amlogic NAND driver support Message-ID: <20190115175232.3d82d4a9@xps13> In-Reply-To: <1547566684-57472-1-git-send-email-jianxin.pan@amlogic.com> References: <1547566684-57472-1-git-send-email-jianxin.pan@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jianxin, Jianxin Pan wrote on Tue, 15 Jan 2019 23:38:02 +0800: > These two patches try to add initial NAND driver support for Amlogic Meson > SoCs, current it has been tested on GXL(p212) and AXG(s400) platform. > > Changes since V8 at [9] > - fix build failre at object_is_on_stack > - update Kconfig as Martin's suggested Thanks for this last version, looks good to me. Could you please send a patch to add a MAINTAINERS entry? Also, can we face any deadly failure if someone compiles this driver without the MMC clock driver updated? Thanks, Miquèl