Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp198979imu; Tue, 15 Jan 2019 19:49:18 -0800 (PST) X-Google-Smtp-Source: ALg8bN4H2I58EDCHWYoetHg9BiQJY/DkW8V8MaFoSCLefXpMtz1781I171K1mU8HKz9HEf3hFlIp X-Received: by 2002:a63:7306:: with SMTP id o6mr6746486pgc.343.1547610558542; Tue, 15 Jan 2019 19:49:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547610558; cv=none; d=google.com; s=arc-20160816; b=KCkDLLeb0A8eTYP8ICz82xAGgKNWHcb8avG6XLStsmRLTHOcz98//8jXxe0kph8+4n beOFk4xG0C3EUZ+sZN0AMOwb0ob8w7IVs9vyqAQaLvoruG49jdCt+8SS2HzYjPwfeW+5 ofv6aTRr5OmckDkm1gXDgVkHxJE1Jao/pARiezA4VQce2kK4YBoFb5GIwSuFD6ACg6i/ CmIEMCuHetIbi+5J2WoV86b01VYTmX7yU0d1eflwXGIJ3u0RGcfj5frZ8oLQ3eznbUNK 0vjSE8NKJcG6Ykx/03TGU9WEpcMqcE2h747l1mbQc8Gx2vA6ZPYBAS5z8yhXyUYySGFT o8kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Pg+vbIWZC0nhPSoGvm7+yI2y4sZupPi8NzY4BMjgkYE=; b=cE3iE9xm4l2DaDbepXhgs4/gkjPyI/Qp+ryD0jWCDQJx3gZDEMXSV795dAgQ3p92Jm qm/+AfvKedDOARC/5Uu58hQ364oOTaMs3Z56fPJO+LLVEwlbumkXTHPm7oQtCRjzUpeL 4uaMSEtCBqq1mU2ifR1fQxQBnPk5Cmkah/X/UMaDQS5wl5miTMrQ5Gsn0uTTENsGo31e jULBQ43YM92yVcKYmKVO6TUOIGFbcMrcUq7tHdgcFDFuQkk/QmlmUPJX8jNu8CWJY4bo E42OLg5CMCxLH8lPFLQQxk27WUUTFP4w313TqhMP8rTAMVSZ4VvmHtqbY8RuawuvH64x iMSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si4699153plo.254.2019.01.15.19.48.58; Tue, 15 Jan 2019 19:49:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730541AbfAORGw (ORCPT + 99 others); Tue, 15 Jan 2019 12:06:52 -0500 Received: from relay.sw.ru ([185.231.240.75]:53218 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728566AbfAORGv (ORCPT ); Tue, 15 Jan 2019 12:06:51 -0500 Received: from [172.16.25.12] by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gjSAm-0004U5-70; Tue, 15 Jan 2019 20:06:44 +0300 Subject: Re: [PATCH v3 1/3] powerpc/mm: prepare kernel for KAsan on PPC32 To: Dmitry Vyukov , Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Nicholas Piggin , "Aneesh Kumar K.V" , Alexander Potapenko , LKML , linuxppc-dev@lists.ozlabs.org, kasan-dev , Linux-MM References: <0c854dd6b110ac2b81ef1681f6e097f59f84af8b.1547289808.git.christophe.leroy@c-s.fr> <801c7d58-417d-1e65-68a0-b8cf02f9f956@c-s.fr> From: Andrey Ryabinin Message-ID: <330696c0-90c6-27de-5eb3-4da2159fdfbc@virtuozzo.com> Date: Tue, 15 Jan 2019 20:07:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/15/19 2:14 PM, Dmitry Vyukov wrote: > On Tue, Jan 15, 2019 at 8:27 AM Christophe Leroy > wrote: >> On 01/14/2019 09:34 AM, Dmitry Vyukov wrote: >>> On Sat, Jan 12, 2019 at 12:16 PM Christophe Leroy >>> wrote: >>> > >>> > In kernel/cputable.c, explicitly use memcpy() in order >>> > to allow GCC to replace it with __memcpy() when KASAN is >>> > selected. >>> > >>> > Since commit 400c47d81ca38 ("powerpc32: memset: only use dcbz once cache is >>> > enabled"), memset() can be used before activation of the cache, >>> > so no need to use memset_io() for zeroing the BSS. >>> > >>> > Signed-off-by: Christophe Leroy >>> > --- >>> > arch/powerpc/kernel/cputable.c | 4 ++-- >>> > arch/powerpc/kernel/setup_32.c | 6 ++---- >>> > 2 files changed, 4 insertions(+), 6 deletions(-) >>> > >>> > diff --git a/arch/powerpc/kernel/cputable.c >>> b/arch/powerpc/kernel/cputable.c >>> > index 1eab54bc6ee9..84814c8d1bcb 100644 >>> > --- a/arch/powerpc/kernel/cputable.c >>> > +++ b/arch/powerpc/kernel/cputable.c >>> > @@ -2147,7 +2147,7 @@ void __init set_cur_cpu_spec(struct cpu_spec *s) >>> > struct cpu_spec *t = &the_cpu_spec; >>> > >>> > t = PTRRELOC(t); >>> > - *t = *s; >>> > + memcpy(t, s, sizeof(*t)); >>> >>> Hi Christophe, >>> >>> I understand why you are doing this, but this looks a bit fragile and >>> non-scalable. This may not work with the next version of compiler, >>> just different than yours version of compiler, clang, etc. >> >> My felling would be that this change makes it more solid. >> >> My understanding is that when you do *t = *s, the compiler can use >> whatever way it wants to do the copy. >> When you do memcpy(), you ensure it will do it that way and not another >> way, don't you ? > > It makes this single line more deterministic wrt code-gen (though, > strictly saying compiler can turn memcpy back into inlines > instructions, it knows memcpy semantics anyway). > But the problem I meant is that the set of places that are subject to > this problem is not deterministic. So if we go with this solution, > after this change it's in the status "works on your machine" and we > either need to commit to not using struct copies and zeroing > throughout kernel code or potentially have a long tail of other > similar cases, and since they can be triggered by another compiler > version, we may need to backport these changes to previous releases > too. Whereas if we would go with compiler flags, it would prevent the > problem in all current and future places and with other past/future > versions of compilers. > The patch will work for any compiler. The point of this patch is to make memcpy() visible to the preprocessor which will replace it with __memcpy(). After preprocessor's work, compiler will see just __memcpy() call here.