Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp216539imu; Tue, 15 Jan 2019 20:16:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN7Hjb6u1G2jID7ZD7kOe65+TXO7NewIHMWtDJPVWdWTG97HUphIfk+o60SuPUCzx/HsQqD3 X-Received: by 2002:a63:86c1:: with SMTP id x184mr6874237pgd.305.1547612192541; Tue, 15 Jan 2019 20:16:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547612192; cv=none; d=google.com; s=arc-20160816; b=i3dvE9byNGeAPQC2lPKfSIZJt2rQIlNUOGYnSXSLxz8kgcsoHcDY/uDLAwOO9+O6Iu iSPyhwJFkFAV+dI1y9AUykC7GK/a3vTri53qhsboZdBLEFD81rHtXNSrv1KBUA0e1dS4 xzM55HOXGlhOl7AN31sMkyD9VxWj3DufbJ1NGhVyGjbiPppQ4eVABi9ZUsArA0kMBEBU JYPa8dvkfZxl58BqvwnM2IrJQZZLis5/s1TraKGIMtOgYxngwWrBaSGheeL/0cN5uI81 gemEXk4jb0FqBhtZdWNDlKrXbNWsiv4QltHpKTwMxU1E6uoIjLjmA5W/NzGyXhKXId5B 8kjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=DqESrV1Md3KszIErJ0wZVSAMlnX0oTQWAwSFsUszNx0=; b=gn/NjTVAhi1G4rj+jExxJ7Bwd7OVSIykQM4NNXXHyR2T97CvnDFpQJp/YB1cGdqDLv 2NRkTW6LalBawrDoY/+GYY8c9+eM20GDskxnOysiq4r3aUAasEzeQNkkiNrIEDAXRqXm YJnfyW874m1M3Ko4TKf4wDQOO00N+4gHG1TrJqJy0kAH9e04Q1mZ5wHjE2k220qS7eyt TjCTEr9yXlYAlB1Yh/yTljgRI0tdOUTB5E/rbfWPxAwlopPMcaGfjnRkpbpOzXaP8DX0 U2wRiljFFD2U9yiBFuLib4uG0TBTa1SNsC422kTCFlqSRlY0tEMsCLU2qek37MhLSq9p ytYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j22si4744025pgj.244.2019.01.15.20.16.14; Tue, 15 Jan 2019 20:16:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733086AbfAORSa (ORCPT + 99 others); Tue, 15 Jan 2019 12:18:30 -0500 Received: from mail.bootlin.com ([62.4.15.54]:60753 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730217AbfAORSa (ORCPT ); Tue, 15 Jan 2019 12:18:30 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id D104F20750; Tue, 15 Jan 2019 18:18:27 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from localhost (alyon-652-1-22-18.w109-213.abo.wanadoo.fr [109.213.145.18]) by mail.bootlin.com (Postfix) with ESMTPSA id 951AA206A6; Tue, 15 Jan 2019 18:18:17 +0100 (CET) From: Alexandre Belloni To: Greg Kroah-Hartman , Vladimir Zapolskiy Cc: Sylvain Lemieux , Roland Stigge , Jiri Slaby , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH] tty: serial: lpc32xx_hs: fix missing console boot messages Date: Tue, 15 Jan 2019 18:18:14 +0100 Message-Id: <20190115171814.21789-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When probing the HSUART, it is put in loopback mode in order to prevent a potential issue that may happen on RX (Errata HSUART.1). serial_lpc32xx_startup() moves it out of loopback mode but this is too late to get the kernel boot messages before userspace opens the device. Also get out of loopback mode in lpc32xx_hsuart_console_setup(). Signed-off-by: Alexandre Belloni --- drivers/tty/serial/lpc32xx_hs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index d1d73261575b..f4e27d0ad947 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -151,6 +151,8 @@ static void lpc32xx_hsuart_console_write(struct console *co, const char *s, local_irq_restore(flags); } +static void lpc32xx_loopback_set(resource_size_t mapbase, int state); + static int __init lpc32xx_hsuart_console_setup(struct console *co, char *options) { @@ -170,6 +172,8 @@ static int __init lpc32xx_hsuart_console_setup(struct console *co, if (options) uart_parse_options(options, &baud, &parity, &bits, &flow); + lpc32xx_loopback_set(port->mapbase, 0); /* get out of loopback mode */ + return uart_set_options(port, co, baud, parity, bits, flow); } -- 2.20.1