Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261885AbUA3QhE (ORCPT ); Fri, 30 Jan 2004 11:37:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261931AbUA3QhE (ORCPT ); Fri, 30 Jan 2004 11:37:04 -0500 Received: from fw.osdl.org ([65.172.181.6]:59045 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261885AbUA3QhA (ORCPT ); Fri, 30 Jan 2004 11:37:00 -0500 Date: Fri, 30 Jan 2004 08:36:41 -0800 (PST) From: Linus Torvalds To: Krzysztof Halasa cc: erik@hensema.net, linux-kernel@vger.kernel.org Subject: Re: Lindent fixed to match reality In-Reply-To: Message-ID: References: <20040129193727.GJ21888@waste.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 31 On Thu, 29 Jan 2004, Krzysztof Halasa wrote: > Erik Hensema writes: > > >> void *foo(void) { > >> > >> instead of > >> > >> void * > >> foo(void) { > > > > You just nicely broke 'find . -name *.c | xargs grep ^foo'. > > It was never working with the kernel, so no one can break it. > Just use a little better pattern or use a tool which parses C code. Indeed. Never _ever_ make your source-code look worse because your tools suck. Fix the tools instead. There are tons of tools that index sources properly, so please don't try to make code look like crap because of using broken things like '^foo'. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/