Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190114210426.177543-1-trong@android.com> <20190114210426.177543-5-trong@android.com>
 <CAK7LNAQe5CUhvvyMDfS2t+Y+t9B5SwUOah6V==9Ds+HR2SL5nQ@mail.gmail.com>
In-Reply-To: <CAK7LNAQe5CUhvvyMDfS2t+Y+t9B5SwUOah6V==9Ds+HR2SL5nQ@mail.gmail.com>
From:   Tri Vo <trong@android.com>
Date:   Tue, 15 Jan 2019 09:52:10 -0800
Message-ID: <CANA+-vBi9nQ6tH=fY0xqrY4i6pFsXikrnaaBZ6BdEv7q92tT2Q@mail.gmail.com>
Subject: Re: [PATCH 4/4] gcov: clang: pick GCC vs Clang format depending on compiler
To:     Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     oberpar@linux.ibm.com, Greg Hackmann <ghackmann@android.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 14, 2019 at 5:25 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> On Tue, Jan 15, 2019 at 6:07 AM Tri Vo <trong@android.com> wrote:
> >
> > Clang gcov format is only supported by Clang compiler, and Clang
> > compiler only supports Clang format.
>
>
> If so, what is the point of putting GCOV_FORMAT_CLANG into the
> choice menu?
>
>
> You can choose the format only when you are using GCC.
>
> I think the following is more sensible:
>
>
> if GCOV_KERNEL
>
> config GCOV_PROFILE_ALL
>          ....
>
>
> choice
>         prompt "Specify GCOV format for GCC"
>         depends on CC_IS_GCC
>         ...
>
> config GCOV_FORMAT_3_4
>         bool "GCC 3.4 format"
>         depends on GCC_VERSION < 40700
>         ...
>
> config GCOV_FORMAT_4_7
>         bool "GCC 4.7 format"
>         ...
>
> endchoice
>
>
> config GCOV_FORMAT_CLANG
>          def_bool CC_IS_CLANG
>
> endif
>
>
>
>
>
> Or, you can delete GCOV_FORMAT_CLANG
> if you write the Makefile like follows:
>
>
>
> obj-y := base.o fs.o
> obj-$(CONFIG_GCOV_FORMAT_3_4) += gcc_base.o gcc_3_4.o
> obj-$(CONFIG_GCOV_FORMAT_4_7) += gcc_base.o gcc_4_7.o
> obj-$(CONFIG_CC_IS_CLANG)     += clang.o

Thanks for the suggestion! It is more sensible than the current
approach. I'll send an update.