Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp463614imu; Wed, 16 Jan 2019 02:01:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN6NQ20QocFt1ZDhomD8B8FPBCukO/jPeH2wmkUqqygSfAi2dIHQc6QJBEuXthJAnwmeDbr/ X-Received: by 2002:a63:f65:: with SMTP id 37mr8035124pgp.238.1547632874520; Wed, 16 Jan 2019 02:01:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547632874; cv=none; d=google.com; s=arc-20160816; b=Q9MxUKhTI+hvtvXOoFqPI5sPwBMdOoynwXAXaWj8TaPJhHwpAHqr31UEpZ0avfXe6A 6cbjetEvfli7OodDsIYF2Jwzb2eKmPOqFnKJE8yZtVXR22TMGXD1SRy97CSFoI8H52QD TqNQa6YpfVdRNG2s/FBZnyeocPLBvY18/0Q4ADty1u8lMyJcBWYJRsrIRlmXwsRRi2qx /+gno5nyGXtzksO5ZWtCfrOjFMxex2GRandi+2iBRhcQeoPhzU+QSy4MwslkKhqldxc6 NC59TQS/zS53yhQW64BmgWcjuvhB7/iB6pkPpD3vMZx7gpwqy/Taw8pwopFMZU7E2qDQ TZZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:dkim-signature; bh=Ii7YU/jXaruO/Mt/Yy7vVi3JkjrzxrH2AytJsE7c0ZY=; b=0ZXp2UDalHjN+3qe22/sgk0DRyoHWj3jjhLhv2e17CbgO8t5qH4bDzlKya2eiOI0c0 0pNoiQ5dH5HGKpzJfhqcs3TKO7K5qrQbgBdTBMlnBkr0vJvZq8Syg/wn6O+awHhJ615s fbhEW+Vpc4kaRYBHXQiZr2e3b2+jB1wGhnxSdto+g4DLyHGkknes6EcP0KszAPpWg8xf IlDTfWvIgjCQmCs7rk6pkdRfY14KfMfb9iRqg2XeDHejKL1tTh9kjKXJAiHyvBHMeug1 gbAFX/bXoqtEDLLtY97uWcCJN1ia9qLHhlTqc1OY6IVJemkzL2qpTV+yzR1wbohlOseh aXqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ocallahan-org.20150623.gappssmtp.com header.s=20150623 header.b="c/WGDa2V"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l129si6519829pfl.284.2019.01.16.02.00.58; Wed, 16 Jan 2019 02:01:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ocallahan-org.20150623.gappssmtp.com header.s=20150623 header.b="c/WGDa2V"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389370AbfAOThD (ORCPT + 99 others); Tue, 15 Jan 2019 14:37:03 -0500 Received: from mail-lj1-f180.google.com ([209.85.208.180]:34709 "EHLO mail-lj1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731673AbfAOThD (ORCPT ); Tue, 15 Jan 2019 14:37:03 -0500 Received: by mail-lj1-f180.google.com with SMTP id u89-v6so3401991lje.1 for ; Tue, 15 Jan 2019 11:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ocallahan-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=Ii7YU/jXaruO/Mt/Yy7vVi3JkjrzxrH2AytJsE7c0ZY=; b=c/WGDa2VD8B4Fo33hDJTXnG3E+NSwq5uHtYhcNHdz37dW6Pgu79jk9vgZNAu+GATJT +gBrLP2f2j/4euHCBdLnsgz0RtLuoFkwWkuZgP3XuKOEIscq0/u/lX9oiSf3hQQ/Wv8E 5ekoNp+fXdMcJAOaBCqTJv5uT7y8hJ0UttheCYc/YfSswrcH1PchgaXSKsR06l9nKZEw Bx88Syyghh1O6b6X0isuM0Cbwdbs+oxor5a05nBMCX9xCsWepdiTGlq4KowBnaDR0CG/ iLUH4/GmkcGzxWbBcmpqay+igG6SPmrXbsYtPEg/fXpT65yytE/FZBj9n5MAgjfYQqLn wVRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=Ii7YU/jXaruO/Mt/Yy7vVi3JkjrzxrH2AytJsE7c0ZY=; b=GpmyMjR9l7NCt4QjThJEbQNhbJh+H6b6955AVtPsSnas+XnjEUB+X8D7I2grkTQegc Wb/Tg1ndVm2o2onBDf9l/KMtIaMDvQc4zyrJ6ZX+qOx+3mKpIREuFJLFnbtPwRQvO42g ENfg1sEZofoVWxN5ERTnifMSC5qUUioTIFNbSZU1J3CmzfJ1ZbLvdYdgogw1XgOAXqvf Y1UureREil7Sb4paIE4bz0IiX8IJORirkePk6YpiS0Y+aH7ckSSFEMo1wSAPxpLBrYls CgIZxyEKJghFAwuM5l67l8NFIqNfkOwNeVuRqX89bKEsn6ELma/UlK8Ljh0XNuMzGQWV OZ4w== X-Gm-Message-State: AJcUukdQTKQpddXBxihdJqVb8vTlomcDt9v/xFMipiZTHw2TsPC5B0a5 G77HRSDvHb3atlyP+1rCOMf3QpyljTJXhrJI8HQ= X-Received: by 2002:a2e:9a16:: with SMTP id o22-v6mr3896579lji.112.1547581020955; Tue, 15 Jan 2019 11:37:00 -0800 (PST) MIME-Version: 1.0 References: <87won67580.fsf@xmission.com> In-Reply-To: <87won67580.fsf@xmission.com> Reply-To: robert@ocallahan.org From: "Robert O'Callahan" Date: Wed, 16 Jan 2019 08:36:49 +1300 Message-ID: Subject: Re: Regression in 32-bit-compat TIOCGPTPEER ioctl due to 311fc65c9fb9c966bca8e6f3ff8132ce57344ab9 To: "Eric W. Biederman" Cc: LKML , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 8:25 PM Eric W. Biederman wrote: > Can you confirm this fixes it for you? Sorry --- I made a mistake. It looks like this is already fixed on master, by commit e21120383f2dce32312f63ffca145ff8a87d41f5 (though I don't think Al Viro knew he was fixing this bug). So, nothing to do here. Thanks, Rob -- Su ot deraeppa sah dna Rehtaf eht htiw saw hcihw, efil lanrete eht uoy ot mialcorp ew dna, ti ot yfitset dna ti nees evah ew; deraeppa efil eht. Efil fo Drow eht gninrecnoc mialcorp ew siht - dehcuot evah sdnah ruo dna ta dekool evah ew hcihw, seye ruo htiw nees evah ew hcihw, draeh evah ew hcihw, gninnigeb eht morf saw hcihw taht.