Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp494867imu; Wed, 16 Jan 2019 02:37:06 -0800 (PST) X-Google-Smtp-Source: ALg8bN7VNlrXVJm40uvbdZwBhXe+AL14rctWTbOLasARJivPzAnRZ7gvHMGQ1KL1al7KjWDF4KB5 X-Received: by 2002:a62:870e:: with SMTP id i14mr9253538pfe.41.1547635026758; Wed, 16 Jan 2019 02:37:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547635026; cv=none; d=google.com; s=arc-20160816; b=NRGU06o81NrSzZvsDZ0LevVkINqZKEONHSAWuZgCpDKwftaF4D3yqdCjPqrHZ+YsM1 C2k8E1ZIqpBMa/Sil8UaNjzVm6g1to3AXxWtmafr4KojMZx+kHaK6WfU3XR6IZ4dMnTt W7h3PDMSIi25kgYoAwaQTUYwj4iQF/Xjkeo5e3DAJ3GxD1ln1a9tlLtE0HZdgcsX5cuh NSBil+GaguvuvcjSsJ4yG0tW1z0bPUCsB8Xu876BPM/+9WfVFYrH2JL1wuTYkliMXUF4 JZFYs7n8UTH5rf9+ellYXus6/Gj9O5QX78h44sntcT7ysl9cxYfftYw9u5s1FUPy0Ofd jiXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=vTwjV8Z9149BVSSK7fdSWFacNeADPC0eQaIXkteG95s=; b=euuLCusjvChE2e6a/Mn4m3L91gBCWQrW98MG64upRoKzPGsiHhsDgd05rtO+KwGb+j hjSCH12/a2BbllQwyE8OuVT/5yvWp5rfGUNABuxc+mndY9vMu5hTM5n2X8Q2PySAnKqO doRVn2q1p+kW9Xw/Cv0Tp4fhBgwxEqxOQCW1DFIwlPGNp+MFdc0A58OTzqmm1ZWKft0F A4Dh2h9mOizyObUvV1HN6hdUIIOYRvbvxQO+3v/oArrxwDZoq6m2tzPfwWDkh0NtJAVT kDJbGQ9ddP1kJkAlp3PnAQLtLLcE6Q1E6Wy1vaD4Uonbp4M/BmKV0RLCI5i5Z1zywg5v ZFaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ty8b1OIN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si5582405pgk.312.2019.01.16.02.36.48; Wed, 16 Jan 2019 02:37:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ty8b1OIN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389199AbfAOTIr (ORCPT + 99 others); Tue, 15 Jan 2019 14:08:47 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:57208 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732387AbfAOTIp (ORCPT ); Tue, 15 Jan 2019 14:08:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=vTwjV8Z9149BVSSK7fdSWFacNeADPC0eQaIXkteG95s=; b=ty8b1OINnPHC Q1Jsgh1rYNi+HEWtqVrj9Qrg1Ogcp7szXS7jMua27/WSwqf4jknz6XRRDTWpFNYbFaaybl9A8p8f6 xQYxFLIUtdNqXV9J1sJWKmcmcwM+wCFnfkJqbyywzJ3axl1C2TlsQjZDfA/O4ivf3iu6ZJL0cYVYK C8r9M=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gjU4j-00028B-NJ; Tue, 15 Jan 2019 19:08:37 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 4BBE11127848; Tue, 15 Jan 2019 19:08:37 +0000 (GMT) From: Mark Brown To: Vignesh R Cc: stable@vger.kernel.org, David Lechner , David Lechner , Mark Brown , Mark Brown , David Lechner , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-spi@vger.kernel.org Subject: Applied "spi: omap2-mcspi: Fix DMA and FIFO event trigger size mismatch" to the spi tree In-Reply-To: <20190115065832.23705-1-vigneshr@ti.com> X-Patchwork-Hint: ignore Message-Id: <20190115190837.4BBE11127848@debutante.sirena.org.uk> Date: Tue, 15 Jan 2019 19:08:37 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: omap2-mcspi: Fix DMA and FIFO event trigger size mismatch has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From baf8b9f8d260c55a86405f70a384c29cda888476 Mon Sep 17 00:00:00 2001 From: Vignesh R Date: Tue, 15 Jan 2019 12:28:32 +0530 Subject: [PATCH] spi: omap2-mcspi: Fix DMA and FIFO event trigger size mismatch Commit b682cffa3ac6 ("spi: omap2-mcspi: Set FIFO DMA trigger level to word length") broke SPI transfers where bits_per_word != 8. This is because of mimsatch between McSPI FIFO level event trigger size (SPI word length) and DMA request size(word length * maxburst). This leads to data corruption, lockup and errors like: spi1.0: EOW timed out Fix this by setting DMA maxburst size to 1 so that McSPI FIFO level event trigger size matches DMA request size. Fixes: b682cffa3ac6 ("spi: omap2-mcspi: Set FIFO DMA trigger level to word length") Cc: stable@vger.kernel.org Reported-by: David Lechner Tested-by: David Lechner Signed-off-by: Vignesh R Signed-off-by: Mark Brown --- drivers/spi/spi-omap2-mcspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 2fd8881fcd65..8be304379628 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c @@ -623,8 +623,8 @@ omap2_mcspi_txrx_dma(struct spi_device *spi, struct spi_transfer *xfer) cfg.dst_addr = cs->phys + OMAP2_MCSPI_TX0; cfg.src_addr_width = width; cfg.dst_addr_width = width; - cfg.src_maxburst = es; - cfg.dst_maxburst = es; + cfg.src_maxburst = 1; + cfg.dst_maxburst = 1; rx = xfer->rx_buf; tx = xfer->tx_buf; -- 2.20.1