Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed
 AST24xx/AST25xx
To:     Joel Stanley <joel@jms.id.au>
Cc:     devicetree <devicetree@vger.kernel.org>,
        Ryan Chen <ryan_chen@aspeedtech.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Andrew Jeffery <andrew@aj.id.au>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        James Feist <james.feist@linux.intel.com>,
        Vernon Mauery <vernon.mauery@linux.intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Haiyue Wang <haiyue.wang@linux.intel.com>
References: <20190107214136.5256-1-jae.hyun.yoo@linux.intel.com>
 <20190107214136.5256-7-jae.hyun.yoo@linux.intel.com>
 <CACPK8XfMyXfomepZEPJCr=A-cCPw-CVAZ0B2CuKn7oXCNz6LbQ@mail.gmail.com>
 <abaef001-a769-ec5d-45f0-02a994fdbee6@linux.intel.com>
 <CACPK8XdBSYHB+S8Sp8Y=J0cK9D=coa+coQj3S7TEFs9DJ8Ljxg@mail.gmail.com>
From:   Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Message-ID: <17179a43-9ac7-366a-bfe6-044e80875a06@linux.intel.com>
Date:   Tue, 15 Jan 2019 15:36:43 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <CACPK8XdBSYHB+S8Sp8Y=J0cK9D=coa+coQj3S7TEFs9DJ8Ljxg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/15/2019 3:14 PM, Joel Stanley wrote:
> On Tue, 15 Jan 2019 at 09:49, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
>>>> +       /**
>>>> +        * We check that the regmap works on this very first access,
>>>> +        * but as this is an MMIO-backed regmap, subsequent regmap
>>>> +        * access is not going to fail and we skip error checks from
>>>> +        * this point.
>>>
>>> Why do you use a regmap for this driver? AFAICT it has exclusive
>>> ownership over the register range it uses, which is sometimes a reason
>>> to use a regmap over a mmio region.
>>>
>>> I'm not sure if you've ever disassembled drivers/base/regmap/regmap.o,
>>> but if you do you will find that a single mmio read turns into
>>> hundreds of instructions.
>>>
>>
>> No specific reason. regmap makes some overhead as you mentioned but it
>> also provides some advantages on access simplification, endianness
>> handling and register dump at run time. I would not insist using of
>> regmap if you prefer using of raw readl and writel. Do you want replace
>> regmap with readl and writel in this driver?
> 
> I think that would be best.
> 
> You raise some good points about the regmap API, and you're not alone
> in using it for these reasons. We should look in to providing a
> suitable API without the overhead, or making regmap more efficient for
> the mmio case.
> 

Okay. I'll rewrite this driver code using readl and writel instead of 
regmap mmio. Thanks again for your review!

Regards,
Jae