Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 16 Jan 2019 01:35:35 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 00/15] powerpc/32s: Use BATs/LTLBs for
 STRICT_KERNEL_RWX
Message-ID: <20190116003535.GE22334@latitude>
References: <cover.1547132681.git.christophe.leroy@c-s.fr>
 <20190113181621.GA22334@latitude>
 <714e78ba-1e92-a856-3dd6-a1fb96ad3785@c-s.fr>
 <20190113210227.GB22334@latitude>
 <334b1b02-b652-499c-904e-09e6f7164b8c@c-s.fr>
 <20190115003353.GD22334@latitude>
 <b37e3635-9c69-0cfc-1283-25459b394033@c-s.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qFgkTsE6LiHkLPZw"
Content-Disposition: inline
In-Reply-To: <b37e3635-9c69-0cfc-1283-25459b394033@c-s.fr>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--qFgkTsE6LiHkLPZw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 15, 2019 at 07:51:01AM +0100, Christophe Leroy wrote:
> Le 15/01/2019 =C3=A0 01:33, Jonathan Neusch=C3=A4fer a =C3=A9crit=C2=A0:
[...]
> > I've checked it patch-by-patch now (with STRICT_KERNEL_RWX):
> >=20
> > - patches 1 and 2 build and boot fine
> > - patches 3 to 6 build, but fail to boot with this error:
>=20
> The bug is in patch 2, mmu_mapin_ram() should return base instead of
> returning 0 when __map_without_bats is set.

Indeed, with this change, I can boot up to patch 11.

> > - patches 12 to 15 build but fail to boot with this error:
>=20
> Thats the one we need to really understand.
>=20
> Do you have modules ? If so, can you try without ?

I don't use any modules in my test setup, but I have module support
enabled. Disabling CONFIG_MODULES makes no difference, as far as I can
see (I get the same backtrace with memblock_alloc_base+0x34/0x44).

> > 	[    0.000000] [c0f1ff30] [c00280f0] panic+0x144/0x324 (unreliable)
> > 	[    0.000000] [c0f1ff90] [c0c18a34] memblock_alloc_base+0x34/0x44
> > 	[    0.000000] [c0f1ffa0] [c0c071e0] MMU_init_hw+0xcc/0x300
> > 	[    0.000000] [c0f1ffd0] [c0c06554] MMU_init+0x12c/0x198
> > 	[    0.000000] [c0f1fff0] [c0003418] start_here+0x40/0x78

With a few printks[1], I traced this error, and got the following
result:

[    0.000000] __memblock_find_range_top_down(1000:1800000, 100000:100000, =
ffffffff, 0)
[    0.000000] __memblock_find_range_top_down: in loop, 10000000:13f00000
[    0.000000] __memblock_find_range_top_down: in loop, 179962d:1800000
[    0.000000] __memblock_find_range_top_down: in loop, 1676000:17987a0
[    0.000000] __memblock_find_range_top_down: nothing found :(

The limit of 0x1800000 comes from setup_initial_memory_limit, which only
considers the first memblock, but the second memblock starts at 256MiB,
so it wouldn't be usable anyway, according to the comment in
setup_initial_memory_limit.

Thinning the kernel down a bit actually makes it boot again. Ooops...!
Maybe enabling CONFIG_STRICT_KERNEL_RWX has made it just large enough to
fail the hash table allocation, but there may have been other factors
involved (I'm not sure exactly).  Sorry for the confusion!


Jonathan

[1]:
diff --git a/mm/memblock.c b/mm/memblock.c
index 022d4cbb3618..66d588e08487 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -215,8 +215,11 @@ __memblock_find_range_top_down(phys_addr_t start, phys=
_addr_t end,
 	phys_addr_t this_start, this_end, cand;
 	u64 i;
=20
+	printk("%s(%x:%x, %x:%x, %x, %x)\n", __func__, start, end, size, align, n=
id, flags);
+
 	for_each_free_mem_range_reverse(i, nid, flags, &this_start, &this_end,
 					NULL) {
+		printk("%s: in loop, %x:%x\n", __func__, this_start, this_end);
 		this_start =3D clamp(this_start, start, end);
 		this_end =3D clamp(this_end, start, end);
=20
@@ -228,6 +231,7 @@ __memblock_find_range_top_down(phys_addr_t start, phys_=
addr_t end,
 			return cand;
 	}
=20
+	printk("%s: nothing found :(\n", __func__);
 	return 0;
 }
=20

--qFgkTsE6LiHkLPZw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAlw+fE8ACgkQCDBEmo7z
X9sj1xAApd7XmkKA6yw+nslWus1bdPEyDtHwpeUR/UUCt5LeCMlsinl7iM+WAPpp
VlDbEdmx3ysIMNj2fq8b6ixGkgevzQFnSmxEj39DOpPnbX2/TowIVyJjVdjru/N8
rIDiARcOs3QhwsTkFsI2nYWF1cHCz9EskoUT5mqynX2q5MfRE6Y36Yz9PIkA6Mu6
rRbE71wAwWPveXgTdlPdZx64LZZdbZ/8lLXCYgFwrS2nKAldrHDAuTCIs5EUcDie
ST6e3ePQUJ5Hksq50CTb4rHHD0LC28mM10XEMLxG5eppOGP0NyVMjKPWmF3535gZ
ROVJcPlT8lpv36EMKL4lft4AQwX80Zc+z5Y4E4xqghaa3xiJcqfM9IFvFJtZ1vQP
piXCYlyNu553V2oXDhYq8/TCRfjVnNODugP0SkyAnS+cal/wg/HjwZuG+CaK/IK0
jjaH5JRZJ8e7K/yuz+jPcanskpJkO5+Dtezry0OYBy+GXeWPo65as/Vi9PVflo7A
nmWK+E3vF1lZ86lYuKp4PW65oT/m1+R8CtFGh0wdh60yu6V0Z/SG0SduU8SdN7iA
YnP/wzIDTDy1EKFeLKd2U3ZEOpDIcA9EPK1jOniB/Ov3gl00EnVoAgz6jZfTHTKU
ZsHTWlBmFihGThto2nLt5D7b97JYnbPGzspfRrYHbBJH4wrD7eQ=
=vJhG
-----END PGP SIGNATURE-----

--qFgkTsE6LiHkLPZw--