Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp970486imu; Wed, 16 Jan 2019 10:27:22 -0800 (PST) X-Google-Smtp-Source: ALg8bN7W/zeKSwtd9YuGZV0EbBC0NRVLmAto5IsXDSHzOrXRoagOjDvG6Dp1UUIcqdgzcd9qdmGg X-Received: by 2002:a17:902:4464:: with SMTP id k91mr9837547pld.13.1547663242264; Wed, 16 Jan 2019 10:27:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547663242; cv=none; d=google.com; s=arc-20160816; b=O89JsaGx/+RHsBS1tHoT0sLp8gjO/5ckM2Ac09j7XD2OXpZf6nOcmLiWA8FOGGdObG p+3hblrCeag9+B2/UFpIcX8KC1asGp4Ofdc+yTxFa8SkDJlc14T68StEa/l9GzL4jv0Q 8v4QQG9Eief97Sidx5pn5JTpCYlAGTbIsKrMaN0FnBo6zH62xS89saespmByuZk60gy6 OyM77+/4WOGH6Ru4r7iOrJPG906pZeIOLtfslLRHtlH29qeYSBzK9CDfk0pjW4r6SZtj a8Rtjqca/MfTcfM8GDInlt0ip7eHnWpL48tR0J9jajRGQMwwFFQZqOIhP6gsYHk39r7n C9IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6llC74dNoPFX0Yna5PP+X5P877058X+BmuHYqQs3lCg=; b=Yy78e8sGY3c0YVB++a6MzDMI93BAygfXJPNYZoI/icJHKR4K2d03wFVlW7KdV/cEKx s1Hicg+aBTS9mIoFu0Kx+aIryIJiGBsS4bNsRhzCvATr+wcrelsnrxLK6TdEbduzm+l1 2yk+BCMXN5Fk3WNFQBCR0WqsxJp0Fl668gULEsFh6p+duPRK0d2LZSoBRG0YN5SPvQYu VjTaAAY5hnAtGoO8zIw04/XYhe35mx6DyqbhUBEiiQIS5fK1TAOBRKLuBCtGWDLjarm2 HZulIN7pnWxoKKgAh+dpWEyS1/PZbDae3bjiQlTLlnk5JpH/8GpwLp2AvbTr/MjkiNdA XNVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jhCFUc8p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p16si6695824pff.272.2019.01.16.10.27.04; Wed, 16 Jan 2019 10:27:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jhCFUc8p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388224AbfAPGxH (ORCPT + 99 others); Wed, 16 Jan 2019 01:53:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:32816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730085AbfAPGxH (ORCPT ); Wed, 16 Jan 2019 01:53:07 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FCAB20859; Wed, 16 Jan 2019 06:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547621586; bh=VmzHOjXjE90OxgcUeoYe1kh49fS9ESRaiLk0XbwWhfI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jhCFUc8p/9kNjAjxkO59OLIN6Sg6NMRJuo9L4R1AssxKASNCYJYGyBALu+IV8VGDs gpuc+V/dZq+0tmTdpGAzxtA/zBkuMKU7t7Nvu6YOz9YDoSSUW6q/ssdpRM0+5nKHh0 /mNmuF9eXu3C0SVrcm4PlB003LxHdcanPXeJ6mrI= Date: Wed, 16 Jan 2019 07:53:04 +0100 From: Greg KH To: Christian Brauner Cc: Wei Yongjun , devel@driverdev.osuosl.org, tkjos@android.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com, joel@joelfernandes.org, maco@android.com Subject: Re: [PATCH -next] binderfs: fix error return code in binderfs_fill_super() Message-ID: <20190116065304.GA26290@kroah.com> References: <1547607664-5612-1-git-send-email-weiyongjun1@huawei.com> <20190116062546.ufoeresnwz3wyxiu@brauner.io> <20190116062825.thzsb5edkihepgm4@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190116062825.thzsb5edkihepgm4@brauner.io> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 07:28:26AM +0100, Christian Brauner wrote: > On Wed, Jan 16, 2019 at 07:25:46AM +0100, Christian Brauner wrote: > > On Wed, Jan 16, 2019 at 03:01:04AM +0000, Wei Yongjun wrote: > > > Fix to return a negative error code -ENOMEM from the new_inode() and > > > d_make_root() error handling cases instead of 0, as done elsewhere in > > > this function. > > > > > > Fixes: 3ad20fe393b3 ("binder: implement binderfs") > > This Fixes tag is technically wrong since this codepath was introduced > by a commit that is still sitting in Greg's char-misc-linus branch. Not > sure how to handle that though. Might just leave it. Use the git commit id of the patch in that branch, it is not going to change as I do not rebase that branch. thanks, greg k-h