Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: comedi: Removed not necessary braces for single
 block
To:     Jitendra Khasdev <jkhasdev@gmail.com>,
        hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <20190115153656.10913-1-jkhasdev@gmail.com>
From:   Ian Abbott <abbotti@mev.co.uk>
Organization: MEV Ltd.
Message-ID: <8c44b247-e44d-aaff-e0af-544b2c4eb4c0@mev.co.uk>
Date:   Wed, 16 Jan 2019 10:44:11 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190115153656.10913-1-jkhasdev@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15/01/2019 15:36, Jitendra Khasdev wrote:
> This patch is used to remove not necessary braces for single if block.
> 
> Signed-off-by: Jitendra Khasdev <jkhasdev@gmail.com>
> ---
>   drivers/staging/comedi/comedi_fops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 5d2fcbfe02af..38980fad8be4 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
>   	unsigned int n_data = MIN_SAMPLES;
>   	int ret = 0;
>   
> -	if (copy_from_user(&insn, arg, sizeof(insn))) {
> +	if (copy_from_user(&insn, arg, sizeof(insn)))
>   		return -EFAULT;
> -	}
> +
>   
>   	n_data = max(n_data, insn.n);
>   
> 

The patch looks fine. Thanks for the fix!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-