Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1032400imu; Wed, 16 Jan 2019 11:31:51 -0800 (PST) X-Google-Smtp-Source: ALg8bN5lDRF0eRSrIZ+Nq0eCs+X/UERPPglkjfN06E94pQ5DYm9jIe6sW5aWqFmsXjwukpdqE2Ky X-Received: by 2002:a63:c24c:: with SMTP id l12mr10405394pgg.146.1547667111642; Wed, 16 Jan 2019 11:31:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547667111; cv=none; d=google.com; s=arc-20160816; b=gWF2kIbPOisR7i+0bkvjvU5vkIYdXTL01S7fxPQe4ECVQAmUSsu26xK2aoPMfBKdbb R5bqZJvb1RplNz+zhsBlhJhmgRAPuAigNHnwqRSufpYjoeGOL0aa5VcFgebbr0XfSKdk wagb4O1xOTqD4+p8YA+w4zCWW5oXzqXYKIxRFoeSFS4SSPuMuqmXO4hZlPV+Hulj1Oaq 28dspTYKrlwucTMYEkS2cWSRZ7n0zrNcvafct4oMpKzeqf1Vs9H3i3TBVWYO3p3N9zku 3U5pREH09qf2csA/pqojUK4AHs52sXMMN0gNqOc8HPuBUz94CqT4L744duxO5KWahSVe ivSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject :from:cc:to; bh=HLQ0BUi/KrPeEh6sXtKBL6X77/kWsiGkq0llKOKEHJI=; b=D8SsgJ4x4qrUO7U8mK6ePy2rgW7dQr0u8x4hfQL1wOk75x6C3gf1n2Sy7ZlksnswB+ tUN67X5niR6s7IfCNrx6DTF4ShpZpD+U3/52quGqdqJgousxg5BiNxJxk+seIAiWmIjJ jFCPXEGW73y0sa5ydxx1Fl+x5vw457Ky6vea6h7JoFH3GR8ZqbiuUVVPSC0xpBmz6qZF wcDOiLz8+rrIfeqsCd0FH4/CGawMtGMUMEGc88QKF3l09qWZfY+89gEq3lW33f7m67TE 9hKKUqIcZg1zfJ3mV0Xk43sgxZ+SviSBN54oYn5zlXYJDCs9ltyvZiO0R54knC4+nIxH ktBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si6896007plr.92.2019.01.16.11.31.33; Wed, 16 Jan 2019 11:31:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392276AbfAPLBT (ORCPT + 99 others); Wed, 16 Jan 2019 06:01:19 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:23960 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731772AbfAPLBT (ORCPT ); Wed, 16 Jan 2019 06:01:19 -0500 Received: from [192.168.108.68] (unknown [213.36.7.13]) (Authenticated sender: marc.w.gonzalez) by smtp3-g21.free.fr (Postfix) with ESMTPSA id CDA2F13F8E8; Wed, 16 Jan 2019 12:01:06 +0100 (CET) To: MSM Cc: LKML , Jeffrey Hugo , Bjorn Andersson , Andy Gross From: Marc Gonzalez Subject: [RFC PATCH v2 0/4] UFS on APQ8098 Message-ID: <88e04336-723f-c157-0384-c5054a73e0a4@free.fr> Date: Wed, 16 Jan 2019 11:50:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, After weeks (literally!) of poking the system at random, Jeffrey found why UFS refused to work on APQ8098: we were not setting the load on the vregs. Difference between v1 and v2: - New patch to add 'regulator-allow-set-load' prop to all vreg nodes - Rename rpmcc node to 'clock-controller' + Add Review tags - Drop UFS pinctrl gymnastics (not required, probably left enabled in bootloader) - Delete GCC_UFS_ICE_CORE_CLK (ICE not used upstream, I think) - Fix sizes of ufsphy register areas based on Jeffrey's feedback - Hack ufshcd_set_vccq_rail_unused into a NOP to work around lock up + reboot Marc Gonzalez (4): arm64: dts: qcom: msm8998: Add rpmcc node arm64: dts: qcom: msm8998: Add UFS nodes Add regulator-allow-set-load ufshcd_set_vccq_rail_unused locks up the board arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 52 +++++++++++++++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 69 +++++++++++++++++++++++ drivers/scsi/ufs/ufshcd.c | 1 + 3 files changed, 122 insertions(+) -- 2.17.1