Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1044882imu; Wed, 16 Jan 2019 11:46:31 -0800 (PST) X-Google-Smtp-Source: ALg8bN5nezRQfePqbuWgEozLbByNYv+WUMVd13oYVE+j6UKP/iO5AlZ2AplC1/k6ITfu85LjOOX/ X-Received: by 2002:a17:902:b093:: with SMTP id p19mr11490884plr.135.1547667991000; Wed, 16 Jan 2019 11:46:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547667990; cv=none; d=google.com; s=arc-20160816; b=dtQIFQq55obnR1XVduqQro+iCEMgc/6uxWYbO4iavMDFw3QlboWJXTEMk+9gaM64jG CZCYUSKbhGLR5sfmXBVfzrTNgvKp7eP/dc8bl0nZx44Dalz8aGmWh0NyYR4ZvV6LzZ4p ZtatHRkFWgM0cko3akWRwEAe0uaY7rOOu6CoUrqQwp6vEHxnhUCsVVQNIlN8tXOoiWoE ltCRFTpMiDDKlVd07JEke8xC/Y9TGGmVc8H5IHtINeHlB+je7ZTj1XJhsI8dUS9fY0VP XSDMZiJOcvGuYRi84spOOjHyZwLpKXVlKn5OnBbFr+vPnvXODCFX2dgV02FUIhGbdI4z ZGvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=7Ui27rX1jcEepdVlsuKZQLHErhgEiUDpKL/CWfcDTgc=; b=NPLP5Z7TILqmeDE03uKQRTH9GDw/HBPZQvJ0rhC4GbqIrshaqZ2KG4ioe35oVbI0YN jBWY79hhlsRdCa+bAlp1afw+djoBKPqHYFFlr71TCqBegvpoxel5eHmLqY7wABgXQjdE Ml3urG8w0TNaSqVLSH7EE2KCsHYDqG8p1Vu86qsaPHC/YKhn/W78Uor+7T3Y0QUWc4qm +lKf8VdOcfrW1VzkE5bsl1U9hT/g7y0pmmB5VC0/W3R8ufP45l8yEBzAqn8xN0e0chwe dSn9YBZCmJkwrsokscTle0Vd9cM+Z2rZ2q/ylR1dUYoMx5ojJCmlzRk79Aep9zUusg+e znKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si4230883pgq.545.2019.01.16.11.46.14; Wed, 16 Jan 2019 11:46:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389873AbfAPL3A (ORCPT + 99 others); Wed, 16 Jan 2019 06:29:00 -0500 Received: from inva021.nxp.com ([92.121.34.21]:58914 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730420AbfAPL3A (ORCPT ); Wed, 16 Jan 2019 06:29:00 -0500 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 487B320001D; Wed, 16 Jan 2019 12:28:58 +0100 (CET) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 3BCEB200018; Wed, 16 Jan 2019 12:28:58 +0100 (CET) Received: from fsr-ub1864-101.ea.freescale.net (fsr-ub1864-101.ea.freescale.net [10.171.82.46]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 9555D2060F; Wed, 16 Jan 2019 12:28:57 +0100 (CET) From: Laurentiu Tudor To: linux-i2c@vger.kernel.org, linux-imx@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, wsa@the-dreams.de Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabio.estevam@nxp.com, leoyang.li@nxp.com, Laurentiu Tudor Subject: [PATCH v2 1/2] i2c: imx: fix dma_request_chan error handling Date: Wed, 16 Jan 2019 13:28:54 +0200 Message-Id: <20190116112855.13824-1-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the correct error pointer when extracting the error code. Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request") Signed-off-by: Laurentiu Tudor --- drivers/i2c/busses/i2c-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 09b124547669..42fed40198a0 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -287,7 +287,7 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx, dma->chan_tx = dma_request_chan(dev, "tx"); if (IS_ERR(dma->chan_tx)) { - ret = PTR_ERR(dma->chan_rx); + ret = PTR_ERR(dma->chan_tx); if (ret != -ENODEV && ret != -EPROBE_DEFER) dev_err(dev, "can't request DMA tx channel (%d)\n", ret); goto fail_al; -- 2.17.1