Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1138961imu; Wed, 16 Jan 2019 13:27:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN4WPY8tJeeJFiFV4FnSXshej+vpyJ4jMcLQVSqUCzQ1l/DVCYky3UPxDOEGHO556fpGRNrQ X-Received: by 2002:a63:3e05:: with SMTP id l5mr10215243pga.96.1547674064327; Wed, 16 Jan 2019 13:27:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547674064; cv=none; d=google.com; s=arc-20160816; b=1KnVU4n4lDhsS4SyxcS8kx9iJ0DKXlrW7o/BwPb7xyScgnd+OYXowWFfSnTYg0RODV 3R/kUNOvrV7i22u6z1c6sL+FNsq76ArqjuAgIlxIbu++i5Q++Akqs6izlg76M5k2hZle euZ8frdR+pPmJK+QH83BTx94VnOUMj+BFjo47cb4hyEdHfoo2f6679W+oTwqxj42Pnj+ z9l5HTTxeWbUvh1TFw+vO2CpIl+H4XZFJj2wpAr6aR7TsDJklA1anZahyphFosJjPNlL YzNEmghbPpgQDD+SHJr0MugWLDk1fbu58a/469z2yF3ueRsZ7IHO9DF2OOs5Dgv85unH maBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=i9EBQmXkMNBYjjztGyv3wx7NdVyHDMd7kO+rKlttGLE=; b=chsOln8/30r83cFVHP0zLR0L+uDpd7S+W2uFn7WjSljjbkwfL8gxYJfVeN9jD50aP9 bu9uM//jNJ5kKa5Fskx2a6OLxKsp+HmMpkXYB/QQNAE5FuKu2JOJLUlxAA/v+gzifAkG hllHOvULit4S1AxLjp8RMzSxto5QLU5LGDiYz0zRuGnsCgA7h0Ck2zHntQDuRmqIvyIh ItP35iPt3AQUinPGXeBxdKXcOzh3Ss5EoudfnUUfL0PSPkfd8bJ/HyqWUSEd/0SYD8Dq h0CTIwvYhUkYIssfNgkGsyt4d4fRCsc84F87luNojHu7uWnwWA9KAwPpVRBk8rnASDHm G+PA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g59si3760323plb.302.2019.01.16.13.27.28; Wed, 16 Jan 2019 13:27:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391980AbfAPKYB (ORCPT + 99 others); Wed, 16 Jan 2019 05:24:01 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:40722 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389494AbfAPKXq (ORCPT ); Wed, 16 Jan 2019 05:23:46 -0500 Received: by mail-lf1-f65.google.com with SMTP id v5so4437087lfe.7; Wed, 16 Jan 2019 02:23:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i9EBQmXkMNBYjjztGyv3wx7NdVyHDMd7kO+rKlttGLE=; b=kkLHzJ00TwNmFhbXq4OLPrfLbKq9G4P6M1rc3Q93jKQ4z1kXHpMR10Lv6yIHfk1SWk XNThPh22hneCiZ2l4W70Jw2rDVhvquMS5HYiycLfDsSixJ6RGxp460h88/ts5jkwogtv 3VrOrnozPGvjcPlebPVQMQEJDA7Jg3kSaDvwuO6M+91FVYDtzblnbnzA++67lzeAkU5/ 9zLY7h6VIG1qmlgPIxAT1SPCKHy1H4p5tQel06qqLQ2Rj33tioZz/hoya/Xvp/foNNjL 7uS5Tpq/HuO0PqhdKd6OSQoDen3fMQlJbswJcrKS7nfHWlwigy5e2ptvriQiwsHCBE31 UIaw== X-Gm-Message-State: AJcUuke/cDUqZtFrnAsz/1smtWLYwm0+nrub0qDWQsyBuKQsIy+3b4dR EM6pxnciCmDb7q62ct86UmE= X-Received: by 2002:a19:4f0c:: with SMTP id d12mr6095572lfb.121.1547634224443; Wed, 16 Jan 2019 02:23:44 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id 1-v6sm942115lju.61.2019.01.16.02.23.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 02:23:40 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1gjiMH-0007vq-T4; Wed, 16 Jan 2019 11:23:41 +0100 From: Johan Hovold To: Hauke Mehrtens Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/3] net: dsa: lantiq_gswip: drop bogus drvdata check Date: Wed, 16 Jan 2019 11:23:35 +0100 Message-Id: <20190116102335.30433-4-johan@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190116102335.30433-1-johan@kernel.org> References: <20190116102335.30433-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The platform-device driver data is set on successful probe and will never be NULL on remove (or we have much bigger problems). Signed-off-by: Johan Hovold --- drivers/net/dsa/lantiq_gswip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index 5792674dd4e4..27d092cab40e 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1126,9 +1126,6 @@ static int gswip_remove(struct platform_device *pdev) struct gswip_priv *priv = platform_get_drvdata(pdev); int i; - if (!priv) - return 0; - /* disable the switch */ gswip_mdio_mask(priv, GSWIP_MDIO_GLOB_ENABLE, 0, GSWIP_MDIO_GLOB); -- 2.20.1