Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1138973imu; Wed, 16 Jan 2019 13:27:45 -0800 (PST) X-Google-Smtp-Source: ALg8bN4dsux+OYnVLi+Tg99UObsq0RNuFZO2qL3wm3F+zSvFPk1RTllW10juEkubrO4X51hPr3NQ X-Received: by 2002:a17:902:8607:: with SMTP id f7mr11753558plo.123.1547674065179; Wed, 16 Jan 2019 13:27:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547674065; cv=none; d=google.com; s=arc-20160816; b=LUzQARuHiTzoMjCZHuhv6su1kr22QqHDcQoS4D6WYLteKHM5VnwNExc6cj+ho44ksh t/zRtvrXZ2Z91Yyl8wcNgCFFSCsd6YbhcqD9s6ZL9GCxL6TLMHhVn6kVMH0DcWi4MkRc bH7otlpPAE8/s6kd7CqC5+jWBbsDHN5qgulD8lqlb//+ZDHJ+AuQW9N/ks0WTyC7SWAC cnhWyNTeO1f5t4VD/uL3hihPGjg8A2xXzImtySAPJHjlNdW5s1N/tPzPS1DKueviWiFt FNUP2w4bl3ZZZfuvSWZ7GGTEea1irK46tgxcNo/fd9GNyRjhbnkSzYCmzIsI+n9SAxJN zNtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=pJ5y+r34Be8kigWKj+hhR8ahXyO53U2Pxhu9H83xqfw=; b=BdUSzBwn0hCaQXkjAMa1tfh/xoBoUwdnyWGzhKvQoHpdZMPGkfQ1/UX7R8jEeNGgTQ 0fuQTw79jhaSUEwuwKsvJGlMwUwfCw0fUSQIEJPc0U7SOhFetBCtalaaiK9YIoCM0XjV MmCKWxJCvrPEBRhC+4iD+16b4OwYlcIjV8Tww1HJ6P/YyGMuB2lV5v0Y79/Og370afS7 ef+GbF0i43ELID/dCKYz+iIQAvxsRwkpgdDd4Oarry/v2s6MzlZ0NYooea/VfAGLcvT9 5DdMGC22Njei2hia/orcq4SbnBRf97mlu9Zw1CYTfYQ+k7BNyJUHVHtV2jBw+uJtJt4j kICQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si7417371pfb.188.2019.01.16.13.27.26; Wed, 16 Jan 2019 13:27:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391969AbfAPKXs (ORCPT + 99 others); Wed, 16 Jan 2019 05:23:48 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:34580 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389312AbfAPKXp (ORCPT ); Wed, 16 Jan 2019 05:23:45 -0500 Received: by mail-lf1-f65.google.com with SMTP id p6so4475181lfc.1; Wed, 16 Jan 2019 02:23:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pJ5y+r34Be8kigWKj+hhR8ahXyO53U2Pxhu9H83xqfw=; b=VZZ02mxiD2T53Whtw4YvEvvajA7BpUHlcKUkLxnHwASyf6OBkSGa1g2q6dHI8T80Sg KjyJ/EJ/RNaGshIm2UzW4T9y30/mo+TLPa1ODkyjnpmA4uanqReP2/WXTPhQ4j7veib7 kZgKESg940fcXvkc2OhEd/qCDf59WH43ERel2cjYyIRiTD1cxhO2RT5Q8VznaXH/tK/G SFt9Vwk4PQOAZ8d7L804wzDihhDbnDRqF5aLqkUxqMfdpQaD7UJHyq/drTn7Rpl4nF0j cQWE82TIj+OCtrbInJ1PyLP1ESX2jUpuglfA+tu67yEfxaeztxU+dY35o+HlrmlgOgKG nIsQ== X-Gm-Message-State: AJcUukc+n2NNd9zXkGmG9KomZqa3GsmxkarjtKYhNhJ9ZYP/sJnftAPN nEvNTw6ftV/qch/TVGsA1JW8q/Nv X-Received: by 2002:a19:4f0c:: with SMTP id d12mr6095440lfb.121.1547634222245; Wed, 16 Jan 2019 02:23:42 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id y14-v6sm956481ljj.55.2019.01.16.02.23.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 02:23:40 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1gjiMH-0007vh-Nh; Wed, 16 Jan 2019 11:23:41 +0100 From: Johan Hovold To: Hauke Mehrtens Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable Subject: [PATCH 1/3] net: dsa: lantiq_gswip: fix use-after-free on failed probe Date: Wed, 16 Jan 2019 11:23:33 +0100 Message-Id: <20190116102335.30433-2-johan@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190116102335.30433-1-johan@kernel.org> References: <20190116102335.30433-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make sure to disable and deregister the switch on late probe errors to avoid use-after-free when the device-resource-managed switch is freed. Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Cc: stable # 4.20 Cc: Hauke Mehrtens Signed-off-by: Johan Hovold --- drivers/net/dsa/lantiq_gswip.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index 693a67f45bef..b06c41c98de9 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1099,7 +1099,7 @@ static int gswip_probe(struct platform_device *pdev) dev_err(dev, "wrong CPU port defined, HW only supports port: %i", priv->hw_info->cpu_port); err = -EINVAL; - goto mdio_bus; + goto disable_switch; } platform_set_drvdata(pdev, priv); @@ -1109,6 +1109,9 @@ static int gswip_probe(struct platform_device *pdev) (version & GSWIP_VERSION_MOD_MASK) >> GSWIP_VERSION_MOD_SHIFT); return 0; +disable_switch: + gswip_mdio_mask(priv, GSWIP_MDIO_GLOB_ENABLE, 0, GSWIP_MDIO_GLOB); + dsa_unregister_switch(priv->ds); mdio_bus: if (mdio_np) mdiobus_unregister(priv->ds->slave_mii_bus); -- 2.20.1