Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <b42e37ab06ae3efa244a35df801e2126fd692bb7.camel@bootlin.com>
Subject: Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle
 first
From:   Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To:     Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Chen <Peter.Chen@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Wed, 16 Jan 2019 15:22:40 +0100
In-Reply-To: <20190116144429.7df1d0c5@windsurf>
References: <20190116101051.21202-1-paul.kocialkowski@bootlin.com>
         <20190116115350.3daa9b4f@windsurf>
         <554a5b4f463df6551846cfdc3b043d3f1d99381f.camel@bootlin.com>
         <20190116144429.7df1d0c5@windsurf>
Organization: Bootlin
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.4 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> Well prior to your code, there was already a possibility for both
> ci->phy and ci->usb_phy to be valid. I don't think it's really useful
> to avoid the fallback when a generic PHY has already been found, it's
> confusing. If really you want to clarify that, it should be:
> 
> 	/* Let's first try to find a generic PHY */
> 	ci->phy = devm_phy_get(dev->parent, "usb-phy");
> 	if (IS_ERR(ci->phy)) {
> 		/* Fall back to legacy USB PHY */
> 		ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, "phys", 0);
> 		if (IS_ERR(ci->usb_phy))
> 			ci->usb_phy = devm_usb_get_phy(dev->parent, USB_PHY_TYPE_USB2);
> 	}
> 
> With that, you would only have either ci->phy or ci->usb_phy be valid,
> and never both. With  your change, you can have ci->phy and ci->usb_phy
> both be valid if the legacy USB PHY was found using
> devm_usb_get_phy_by_phandle(), but not if we fell back to
> devm_usb_get_phy().

Okay that makes sense, your suggestion is indeed more consistent with
the existing behavior. I'll go with that in the next revision!

Cheers,

Paul

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com