Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1210216imu; Wed, 16 Jan 2019 14:53:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN6jxTi1KhBzDVWlBavDPrUXjMQSPSusTg4Rt1GXCD8px/nIXNOiEbnMawO4EI/becgA12Ey X-Received: by 2002:a65:5c02:: with SMTP id u2mr11006003pgr.13.1547679194451; Wed, 16 Jan 2019 14:53:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547679194; cv=none; d=google.com; s=arc-20160816; b=GxQtKJNkqARzYSXjmSiQLDkaCQx+I/R2bKgKBNfnPxg6PXb8qtWD8Yp8wf6k4unK5S DKTjfXgisMtkGz365k9PK6xPH94Kh3E14Y1nURLUvRGaCiNA+3DD/eQh0OUx+echJZXn rEvprcHNh7qhuEjBSpLYV+6G0DsCkQytxUdGrg9ZBuajooUHedyX4sXwHN1U2E9FP9Fr 7NtZvel5/TaJ2/e9NJeRdOYYmTxpXAu51sSlVd0BJ4Lk1Mjmb3GCPxJkwNqcPRG6N9Of qzoVUdA1X8nWYRgh6jsOi14326DR3POlQLIR+ceigO+wPcWj/59rgs0Tko1oY9hF8cAD rmnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=r/X/ChlF1WMmExR2X5Lw23OorX1NRf0WBJ7T/qveyS4=; b=kep45IR+K6WlgPv2Fo4dtIvJA6y5IxRxMqfksXOnZ15TCbKtMC+oRE1H6rBG4h1uxC MIt/kIfCHj1y0chOsltrdmi6IInF3EgJ1nBBI4pJnw4FAHOJS7A5RkTh9iGhqTTt9z3F oh0+VZGScCFOPFT6vulsrpzpDJEQvtmPHqwLv+FzgbRY9tkZ9R3SkoEzRp4oW1NqWNnG 0xqany1KG4iGAJJr/vYWtJV/ZlaMMiAxJZsY1P4YXob7y/4ObvAH5fu++nPYmMR9KQ0U ZQV5IotHz2lK7K12Z6p2KGUZ0xd051o+7MlG1ksQrUyQmBTynh/qV5XToQZhXLcxCClX +mwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7si7012830pgh.560.2019.01.16.14.52.58; Wed, 16 Jan 2019 14:53:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394202AbfAPPnQ (ORCPT + 99 others); Wed, 16 Jan 2019 10:43:16 -0500 Received: from muru.com ([72.249.23.125]:33900 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728585AbfAPPnP (ORCPT ); Wed, 16 Jan 2019 10:43:15 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C424F8030; Wed, 16 Jan 2019 15:43:21 +0000 (UTC) Date: Wed, 16 Jan 2019 07:43:11 -0800 From: Tony Lindgren To: Ulf Hansson Cc: Kalle Valo , Eyal Reizer , linux-wireless@vger.kernel.org, Ricardo Salveti , Kishon Vijay Abraham I , Anders Roxell , John Stultz , Jan Kiszka , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH V2] wlcore: sdio: Fixup power on/off sequence Message-ID: <20190116154311.GP5544@atomide.com> References: <20190116113723.15668-1-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190116113723.15668-1-ulf.hansson@linaro.org> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ulf Hansson [190116 11:37]: > During "wlan-up", we are programming the FW into the WiFi-chip. However, > re-programming the FW doesn't work, unless a power cycle of the WiFi-chip > is made in-between the programmings. > > To conform to this requirement and to fix the regression in a simple way, > let's start by allowing that the SDIO card (WiFi-chip) may stay powered on > (runtime resumed) when wl12xx_sdio_power_off() returns. The intent with the > current code is to treat this scenario as an error, but unfortunate this > doesn't work as expected, so let's fix this. > > The other part is to guarantee that a power cycle of the SDIO card has been > completed when wl12xx_sdio_power_on() returns, as to allow the FW > programming to succeed. However, relying solely on runtime PM to deal with > this isn't sufficient. For example, userspace may prevent runtime suspend > via sysfs for the device that represents the SDIO card, leading to that the > mmc core also keeps it powered on. For this reason, let's instead do a > brute force power cycle in wl12xx_sdio_power_on(). > > Fixes: 728a9dc61f13 ("wlcore: sdio: Fix flakey SDIO runtime PM handling") > Signed-off-by: Ulf Hansson > --- > > Changes in v2: > - Keep the SDIO host claimed when calling mmc_hw_reset(). > - Add a fixes tag. This v2 version works for me as tested with: # while [ 1 ]; do ifconfig wlan0 down; ifconfig wlan0 up; done [ 181.364990] wlcore: down [ 182.116424] wlcore: firmware booted (Rev 6.3.10.0.141) [ 182.151641] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready [ 182.166778] wlcore: down [ 182.773132] wlcore: firmware booted (Rev 6.3.10.0.141) [ 182.811096] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready ... Thanks for fixing this issue properly, and feel free to add: Tested-by: Tony Lindgren