Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263942AbUA3VPj (ORCPT ); Fri, 30 Jan 2004 16:15:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263983AbUA3VPj (ORCPT ); Fri, 30 Jan 2004 16:15:39 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:2887 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S263942AbUA3VPa (ORCPT ); Fri, 30 Jan 2004 16:15:30 -0500 To: David Weinehall Cc: Matt Mackall , Andrew Morton , Linus Torvalds , linux-kernel Subject: Re: Lindent fixed to match reality References: <20040129193727.GJ21888@waste.org> <20040129201556.GK16675@khan.acc.umu.se> From: ebiederm@xmission.com (Eric W. Biederman) Date: 30 Jan 2004 14:08:25 -0700 In-Reply-To: <20040129201556.GK16675@khan.acc.umu.se> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 26 David Weinehall writes: > On Thu, Jan 29, 2004 at 01:37:28PM -0600, Matt Mackall wrote: > > I've been fiddling with cleaning up some old code here and suggest the > > following to make Lindent match actual practice more closely. This does: > > > > a) (no -psl) > > > > void *foo(void) { > > > > instead of > > > > void * > > foo(void) { > > > > b) (no -bs) "sizeof(foo)" rather than "sizeof (foo)" > > I can't really see the logic in this, though I know a lot of people do > it. I try to stay consistent, thus I do: If consistency was good in a language we would all be using an RPL or s-expr based language. Communication is clearer with redundant information. Making special cases of common cases is a good thing. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/