Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/4] gcov: clang: link/unlink profiling data set.
To:     Tri Vo <trong@android.com>
Cc:     ghackmann@android.com, ndesaulniers@google.com,
        linux-kernel@vger.kernel.org, kernel-team@android.com,
        Trilok Soni <tsoni@quicinc.com>,
        Prasad Sodagudi <psodagud@quicinc.com>
References: <20190114210426.177543-1-trong@android.com>
 <20190114210426.177543-4-trong@android.com>
From:   Peter Oberparleiter <oberpar@linux.ibm.com>
Date:   Wed, 16 Jan 2019 17:14:03 +0100
MIME-Version: 1.0
In-Reply-To: <20190114210426.177543-4-trong@android.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <03d3a8d0-b9cd-28e9-6365-d74adcd4db59@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14.01.2019 22:04, Tri Vo wrote:
> From: Nick Desaulniers <ndesaulniers@google.com>
> 
> gcov.h defines an interface to access gcov_info data.
> 
> Add Clang implementation of gcov_info_link/gcov_info_unlink interfaces.
> 
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Tri Vo <trong@android.com>
> Tested-by: Trilok Soni <tsoni@quicinc.com>
> Tested-by: Prasad Sodagudi <psodagud@quicinc.com>
> Tested-by: Tri Vo <trong@android.com>
> ---
>  kernel/gcov/clang.c | 33 ++++++++++++++++++++++++++++-----
>  1 file changed, 28 insertions(+), 5 deletions(-)

Please merge this patch into patch 2 as it fixes a number of problems in
that patch.

> 
> diff --git a/kernel/gcov/clang.c b/kernel/gcov/clang.c
> index b00795d28137..ea42deb852f7 100644
> --- a/kernel/gcov/clang.c
> +++ b/kernel/gcov/clang.c

[...]

> +/**
> + * gcov_info_unlink - unlink/remove profiling data set from the list
> + * @prev: previous profiling data set
> + * @info: profiling data set
> + */
> +void gcov_info_unlink(struct gcov_info *prev, struct gcov_info *info)
> +{
> +	if (prev)
> +		list_del(&prev->head);

This is incorrect - gcov_info_unlink should remove info from the list,
not its predecessor prev.


-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany