Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
From:   Song Liu <liu.song.a23@gmail.com>
Date:   Wed, 16 Jan 2019 10:57:49 -0800
Message-ID: <CAPhsuW4EiGUo=p=KYsu+kGWVFRoxEjF3Bq_32QvakQjCsAAjFQ@mail.gmail.com>
Subject: perf segfault in in ordered_events__free()
To:     open list <linux-kernel@vger.kernel.org>,
        Jiri Olsa <jolsa@kernel.org>
Cc:     acme@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

We are debugging a segfault of perf in ordered_events__free().
Disassemble shows the segfault was caused by oe->buff == NULL
in the following line:

        /*
         * Current buffer might not have all the events allocated
         * yet, we need to free only allocated ones ...
         */
        list_del(&oe->buffer->list);

After poking around the code, I suspect it is caused by the following
condition in alloc_event():

        } else if (oe->buffer) {
                new = &oe->buffer->event[oe->buffer_idx];
                if (++oe->buffer_idx == MAX_SAMPLE_BUFFER)
                        oe->buffer = NULL;

Does this theory make sense? If so, what would be the best fix?

Thanks in advance!
Song