Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 16 Jan 2019 22:11:12 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Miroslav Benes <mbenes@suse.cz>
cc:     jpoimboe@redhat.com, jeyu@kernel.org, pmladek@suse.com,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] livepatch: Send a fake signal periodically
In-Reply-To: <20190115164507.14676-2-mbenes@suse.cz>
Message-ID: <nycvar.YFH.7.76.1901162210090.6626@cbobk.fhfr.pm>
References: <20190115164507.14676-1-mbenes@suse.cz> <20190115164507.14676-2-mbenes@suse.cz>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 15 Jan 2019, Miroslav Benes wrote:

> An administrator may send a fake signal to all remaining blocking tasks
> of a running transition by writing to
> /sys/kernel/livepatch/<patch>/signal attribute. Let's do it
> automatically after 15 seconds. The timeout is chosen deliberately. It
> gives the tasks enough time to transition themselves.
> 
> Theoretically, sending it once should be more than enough. However,
> every task must get outside of a patched function to be successfully
> transitioned. It could prove not to be simple and resending could be
> helpful in that case.
> 
> A new workqueue job could be a cleaner solution to achieve it, but it
> could also introduce deadlocks and cause more headaches with
> synchronization and cancelling.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
[ ... snip ... ]
> @@ -400,6 +408,7 @@ void klp_try_complete_transition(void)
>  		 */
>  		schedule_delayed_work(&klp_transition_work,
>  				      round_jiffies_relative(HZ));
> +
>  		return;
>  	}

I somehow didn't like the newly added newline here :) so I've removed it, 
and applied both patches to for-5.1/fake-signal.

Thanks,

-- 
Jiri Kosina
SUSE Labs