Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1297042imu; Wed, 16 Jan 2019 16:39:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN4gOK002VEoXn3wcjBxXAAJ11wCa7EyvdT6XLawtV8KhIKCkI/FHVASLiSFcFTsv5pT3DrB X-Received: by 2002:a17:902:5588:: with SMTP id g8mr12898857pli.22.1547685555214; Wed, 16 Jan 2019 16:39:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547685555; cv=none; d=google.com; s=arc-20160816; b=D/6KLr5/jPMfmOpeHccwEQZpKDa04rBOjaKlT3MYXL09S1r89RbO/bj5febU5IjUfX EJvPpgAfuiTf9ROY60n9MXJyr8TukCJH0u2hvkByCF1A0WUIGuI3ghCT1UHteP1VpyHr Fmcjw57lSR+dXAZwkStZugd/t478X7S69XuQhfBv9rXjxkQzVXguzPB7IIt47tHjxaf8 eCKa6Uodr6plBWkxPJICPUKokjhiFc0uZBeNYzN+8mwElmg6AF8xmZPZF2gdE/jEld9B kRLJC1b0oUWKrVDLeTWyIiqWk/KywPDR+Yhc0/kvUGXe+fk0WEQfv+tct4qOgkMOKNEh kkww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=N7bliBhauSCcFzz9gvVHh3KDXUJe02KDMlreUyQd9Gw=; b=KL9PW1VW8YT7GQSi4hy+Yf6a6ITKDHv8y1MhP+I9qSZOec8pFQNwYjduCc8ONeiDrB HUfwj3TmY0FmDTpqkrO4lbAQn8FJmk4JkH2JEwHtnSCPQCQn0WBzmlSK7UcryKUlOru+ lOjFu0NTmMR01WZ12v+eDP0maU7Qr9QyPqSnZKBvYCQozY7eb0vtRMq7i+dcdLnh5nPZ 050OhwNvxjXPzYSK4wAElgqD400e37uVmfW5af8tqh08ncQurRId+2PjYUX566dEc3sZ ZA351vmoiS0PcZ4GBbq784S0igpcPmgA11eN3xIU9aDEvR6rx6VnnjnMiRM+uQRXXshR DC4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 204si7462267pga.383.2019.01.16.16.38.57; Wed, 16 Jan 2019 16:39:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730618AbfAPViv (ORCPT + 99 others); Wed, 16 Jan 2019 16:38:51 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:45090 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729425AbfAPViu (ORCPT ); Wed, 16 Jan 2019 16:38:50 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A6514126662E6; Wed, 16 Jan 2019 13:38:49 -0800 (PST) Date: Wed, 16 Jan 2019 13:38:49 -0800 (PST) Message-Id: <20190116.133849.1334161442048173947.davem@davemloft.net> To: lucien.xin@gmail.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com, glider@google.com Subject: Re: [PATCH net] sctp: allocate sctp_sockaddr_entry with kzalloc From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Jan 2019 13:38:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long Date: Mon, 14 Jan 2019 18:34:02 +0800 > The similar issue as fixed in Commit 4a2eb0c37b47 ("sctp: initialize > sin6_flowinfo for ipv6 addrs in sctp_inet6addr_event") also exists > in sctp_inetaddr_event, as Alexander noticed. > > To fix it, allocate sctp_sockaddr_entry with kzalloc for both sctp > ipv4 and ipv6 addresses, as does in sctp_v4/6_copy_addrlist(). > > Reported-by: Alexander Potapenko > Signed-off-by: Xin Long Applied and queued up for -stable.