Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1298331imu; Wed, 16 Jan 2019 16:40:47 -0800 (PST) X-Google-Smtp-Source: ALg8bN5BYL+AQv8mBrACNQhzrbOX8OnKsHDeFH/xJY5SS+/glGbN1TjIaOQy+TrO3WKJ1mJ7vQ/C X-Received: by 2002:a63:235f:: with SMTP id u31mr11451049pgm.122.1547685647080; Wed, 16 Jan 2019 16:40:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547685647; cv=none; d=google.com; s=arc-20160816; b=CcJV3tJthws1IQuLlnWySWyxoDqcanE/YbjW/Iibalwa2e9Nq+dqGmy/awOFSDoGIA SC4jwGd/YKh74tNOg+OKOcq4U0MEECAptiwt/lcjnTnHXDeajOoBxU98RJgdnFiniyXP EXuMjnXN+lsLj6HY4Z5vTKrWEWc7Xy2YliLGJptjHOsfjhW+EeM86KUeAr7TBM04mneE bgiTL4Asg4wW+uNrayNsjUKZ8ZvvoCTfS72H37Cn7BZ1BxYBqHBKM0/d3qJ8Jm5XPuCP KszRmD/TazSrYg8Zyg/Ea0rBJbZ66eFaviU4EzkVWT7nZBws9FXH3zDW1wO0iwYQqCDT GxWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=H3SXR8H5ExGfjehbvltCosKG1aTNBAERXUu5lSkwJoY=; b=uDAVHJeh9KSaGK5aec9UzzKrAnhDVuME8idDHgyhsaZ1gL/OXkyW3TR8Danen8moJk FQqNeHuWXRQOpACxfYD76RZfqmzxCouuWxlbN21VK2K7cwY8dKOYxXdVnbQmqN9GPhCP SD1jejGnY4DS520U6oWS0WtEZ/VPJ22MAcszt8JWTl2FE68lfYvmiEs5tWAHqcakQEy1 rLNEvnIedOqdz170ozICruoznfplQZacjhVmlofjcQ1o+9ItfAMLM7D81yupc+fSYG7K 8zfmUvxIpzgG3KTP7tGDTvlSacntMfcbEHBS7RB/d8eT0pBf4r6YrXEl81Kr7tUlCnvD qbmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x12si7718763pgf.454.2019.01.16.16.40.29; Wed, 16 Jan 2019 16:40:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731708AbfAPVyV (ORCPT + 99 others); Wed, 16 Jan 2019 16:54:21 -0500 Received: from mga07.intel.com ([134.134.136.100]:39281 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731095AbfAPVyV (ORCPT ); Wed, 16 Jan 2019 16:54:21 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 13:54:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,487,1539673200"; d="scan'208";a="115223766" Received: from lhaqq1-mobl2.amr.corp.intel.com (HELO localhost) ([10.249.254.231]) by fmsmga007.fm.intel.com with ESMTP; 16 Jan 2019 13:54:17 -0800 Date: Wed, 16 Jan 2019 23:54:16 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] tpm: ppi: Enable submission of optional command parameter for PPI 1.3 Message-ID: <20190116215416.GG25803@linux.intel.com> References: <20190109221103.1897677-1-stefanb@linux.vnet.ibm.com> <20190109221103.1897677-6-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190109221103.1897677-6-stefanb@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2019 at 05:11:03PM -0500, Stefan Berger wrote: > + if (sscanf(buf, "%llu %llu", &tmp[0].integer.value, > + &tmp[1].integer.value) != 2) The alignment is broken here. /Jarkko