Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1323310imu; Wed, 16 Jan 2019 17:14:08 -0800 (PST) X-Google-Smtp-Source: ALg8bN76N6uo6apDHZ1/x8cW/jlA0H6N4SiQrUyrwRyguLCjDWkAkK5cLJwfUEgj4cjqdjKkhfon X-Received: by 2002:a62:7a8b:: with SMTP id v133mr13019390pfc.159.1547687648061; Wed, 16 Jan 2019 17:14:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547687648; cv=none; d=google.com; s=arc-20160816; b=ElX6b058NwFqnauuf6mvis0oVp7TvURJ9Wq7VQSkvznNvDVHNg2UYV/8d67Yv2205s BFaZ/h1xg3tfK5EOKJPcjxk5QEy9I3WWU3Ho5lZ5aiZ2TNyyhBqNshxQyhjRJeSS68yu UePjV/x3dO4bZMPumBIFM9lUyh6YAiO7BbOe096b4KbM5JQYzvGmha0hQzreY0YVQkeN KfWOHRNjD1ZpUon58cNxQcApRJmMvWfTKbslogkGbx4sqhlHugGSB0PnOMrwH1Jjcp8M 3HKXBgv5I1YOr//JMD1NphhvmXOtDO9ry1mL1UGWmXKMQZCSBIhHXIAlIC7a256PvX3X R2yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=yYF9RhlIxdD5GMNL+b1KSoKxY9LA+8qO/xU5eSxvDfc=; b=l6QtbXLV1A28SNB3CZE0aoBvlAUv2H6UF8w/ZZE9vVDUDaom24NsC8XUN07HVdocIG vZck7dcyWVLo2o3SgIi3A0L6dYoLmbSEMghXsPw0t3MfSOgRCattagVFaeAnJmFhVHoH 54UMzrqeObUsEF92oS18b5FlG2gfnxVwdwUR/IKmxZd71Cd0i7GINv7dykqgDMC4LXHp cWQETM+kKW8eQ4rmP5n3OBDZVZmLtIpMq5/r555pAN84kOy4BQPb/z1y7uNGAppJOOhb k76JbuNZbUBQE9aYXcschRoEvWiFaMPqWMD0UsNsnQ1juQsszor4Q6Ikn+QxBW6CoiXI 7tIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n187si39447pfn.83.2019.01.16.17.13.49; Wed, 16 Jan 2019 17:14:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727735AbfAPXoY (ORCPT + 99 others); Wed, 16 Jan 2019 18:44:24 -0500 Received: from namei.org ([65.99.196.166]:56538 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727477AbfAPXoY (ORCPT ); Wed, 16 Jan 2019 18:44:24 -0500 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id x0GNiHdP017131; Wed, 16 Jan 2019 23:44:17 GMT Date: Thu, 17 Jan 2019 10:44:17 +1100 (AEDT) From: James Morris To: Casey Schaufler cc: John Johansen , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, serge@hallyn.com Subject: Re: WARNING in apparmor_cred_free In-Reply-To: <99cd1f6b-682e-7d1f-35ad-b9092d46323f@schaufler-ca.com> Message-ID: References: <0000000000007f604f057f2b8509@google.com> <6213e783-4377-489d-cdfb-1a83f4497076@schaufler-ca.com> <2ccf6281-3f4b-a94a-ed71-31905e583fa6@schaufler-ca.com> <234c868b-4521-0707-a135-d8c24bc179bd@schaufler-ca.com> <99cd1f6b-682e-7d1f-35ad-b9092d46323f@schaufler-ca.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Jan 2019, Casey Schaufler wrote: > >From 47134986133c822e1d88860fa2b108f92c97a7ff Mon Sep 17 00:00:00 2001 > From: Casey Schaufler > Date: Fri, 11 Jan 2019 17:31:50 -0800 > Subject: [PATCH 1/2] LSM: Check for NULL cred-security on free > > Check that the cred security blob has been set before trying > to clean it up. There is a case during credential initialization > that could result in this. > > Signed-off-by: Casey Schaufler Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git fixes-v5.0-rc2 NOTE: For patches which you are submitting for inclusion, start a new thread and include [PATCH] in the subject line. -- James Morris