Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190114102053.16013-1-manivannan.sadhasivam@linaro.org>
 <20190114102053.16013-3-manivannan.sadhasivam@linaro.org> <CAL_JsqJpRPrCpRTpqh1v6JZwpEtZnaeuLTHR+0EiMSoxbk9zeQ@mail.gmail.com>
 <20190116022100.GC15808@dragon>
In-Reply-To: <20190116022100.GC15808@dragon>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 15 Jan 2019 22:07:12 -0600
Message-ID: <CAL_Jsq+myeZ1n4X=KhHZjtPDHnGH=L65xxYbzMrt8Rq6Bur4Bg@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Add devicetree binding for Oxalis
To:     Shawn Guo <shawnguo@kernel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Yang-Leo Li <leoyang.li@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        a.tropschug@ebs-systart.com, m.bittner@ebs-systart.com,
        Amit Kucheria <amit.kucheria@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 15, 2019 at 8:21 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Jan 14, 2019 at 12:02:47PM -0600, Rob Herring wrote:
> > On Mon, Jan 14, 2019 at 4:21 AM Manivannan Sadhasivam
> > <manivannan.sadhasivam@linaro.org> wrote:
> > >
> > > Add devicetree binding for Oxalis board in JSON format. While adding
> > > that, let's fix the description for LS1012A also.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > >  Documentation/devicetree/bindings/arm/fsl.yaml | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index d34fe0749199..0f30142fe316 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -173,12 +173,13 @@ properties:
> > >                - fsl,vf610
> > >                - fsl,vf610m4
> > >
> > > -      - description: LS1021A based Boards
> > > +      - description: LS1012A based Boards
> >
> > Well, yes that was wrong...
> >
> > >          items:
> > >            - enum:
> > >                - fsl,ls1012a-rdb
> > >                - fsl,ls1012a-frdm
> > >                - fsl,ls1012a-qds
> > > +              - ebs-systart,oxalis
> >
> > Sort alphabetically.
> >
> > >            - const: fsl,ls1021a
> >
> > And this is wrong too.
> >
> > I you just change it, then we will be missing an entry for LS1021A.
> > What's the status of that SoC because there is no board dts file? We
> > should not have .dtsi files in the kernel which don't get built.
>
> Hmm, I do not see any LS1021A SoC .dtsi in the tree.  I suspect it's
> just a typo of LS1012A.
>
> @Leo, do we have a LS1021A SoC?

arch/arm/boot/dts/ls1021a.dtsi

Rob