Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181207204318.1920-1-malat@debian.org>
In-Reply-To: <20181207204318.1920-1-malat@debian.org>
From:   Mathieu Malaterre <malat@debian.org>
Date:   Wed, 16 Jan 2019 12:10:30 +0100
Message-ID: <CA+7wUsx7vL_q6KDy_9ZGiaAJnR1SVQq=sbdTHh0NXdk2v7c8Cw@mail.gmail.com>
Subject: Re: [PATCH] mount: Make function to_mnt_ns static
To:     Alexander Viro <viro@zeniv.linux.org.uk>
Cc:     linux-fsdevel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

ping ?

On Fri, Dec 7, 2018 at 9:43 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> In commit 58be28256d98 ("make mntns ->get()/->put()/->install()/->inum()
> work with &mnt_ns->ns"), a new function `to_mnt_ns` was introduced.
> Since this function can be made static, make it so.
>
> Fix warning when compiling with W=1:
>
>   fs/namespace.c:1693:23: warning: no previous prototype for ‘to_mnt_ns’ [-Wmissing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  fs/namespace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index a7f91265ea67..f0cf252d9aa3 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1690,7 +1690,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
>                dentry->d_fsdata == &mntns_operations;
>  }
>
> -struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
>  {
>         return container_of(ns, struct mnt_namespace, ns);
>  }
> --
> 2.19.2
>