Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1471841imu; Wed, 16 Jan 2019 20:50:03 -0800 (PST) X-Google-Smtp-Source: ALg8bN6j4+1Zal2O9ACvSrjUKpTHaliY01X8h0qaHYnjF8rCuhdQKgtfhreIPEo1rCbUZvL8+CtL X-Received: by 2002:a17:902:ac8f:: with SMTP id h15mr13143921plr.245.1547700602955; Wed, 16 Jan 2019 20:50:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547700602; cv=none; d=google.com; s=arc-20160816; b=dCVLMrfbjMwgihFP3dTV7eDu6gVotGWMcvl/scdRtaaGdYUPByOhejsz7NP3T7FcEQ RfuCsa3V+uSuH1fCFrVqrv1OjVaLbWkUXxsO42jUloWa1dGi5r4oe2RC1saIuuPjrOo2 WQttp11+z9nk5MwZJTnpg/jk+axIASHaKzbWU59clMhjWvnTw7dtX/hBYjm/EHcIK1Za pjGRAamTCcjEoR4s34v8C6zzFXAiNqz6czspQ+vnnSo8JxRihpzP1uwamg1qr7JriuSA 4x+AUXOk+xCNmmM2GAiVWNyrLgurBYh51wHTtz5PmnjU646iyq4sNm5jgQPrxKMN9EN2 Cw7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=UK0MxjxKIyEPmnYnF3c4PMPPt84fNjS2uEyknt2HNiw=; b=BSIGAKS6mBgYOCcIoIWlS/ERmwZZaczoEdxaKXrf2Le10mSFCViZCuF/mmspGn3xEe KqN2ixFjU8Red/APQUWqG0Xaa+52jM4AwrttORbdGKFoQwPz/NixtqTs73OJMe83vdDZ vr83T2EcP2T4w0AdMXQBtUJwDNBlRfhiLLpY+Sqg6085hxBdPlG1SdGs3rKf4oNV/+nA +Lm2dcaGfvHNdNNrijW1hEfsQVbkI7r9tBH/CTnpWpL4NKGPX0S5sYCnGsXuvZSV8NIA LompAVZu0QGZYcRGGmCt4PC79dLiuXx6OI9Ns81piSanPKbJvMpevGd7l5jP5Wm0hz09 f/vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e21si504457pgg.571.2019.01.16.20.49.31; Wed, 16 Jan 2019 20:50:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392686AbfAPLvX (ORCPT + 99 others); Wed, 16 Jan 2019 06:51:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:57712 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732464AbfAPLvW (ORCPT ); Wed, 16 Jan 2019 06:51:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C4C1EACA9; Wed, 16 Jan 2019 11:51:20 +0000 (UTC) Subject: Re: [PATCH v3] x86-64/Xen: fix stack switching To: Jan Beulich , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" Cc: Andrew Lutomirski , xen-devel , Boris Ostrovsky , lkml References: <5AF03EBD02000078001C1303@suse.com> <5AF03EBD02000000000F91D6@suse.com> <5AF03EBD02000078001FE590@suse.com> <5C3E1128020000780020DFAD@suse.com> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: <87b0cc15-0e62-db9e-391d-77b42a2626b1@suse.com> Date: Wed, 16 Jan 2019 12:51:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <5C3E1128020000780020DFAD@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/01/2019 17:58, Jan Beulich wrote: > While in the native case entry into the kernel happens on the trampoline > stack, PV Xen kernels get entered with the current thread stack right > away. Hence source and destination stacks are identical in that case, > and special care is needed. > > Other than in sync_regs() the copying done on the INT80 path isn't > NMI / #MC safe, as either of these events occurring in the middle of the > stack copying would clobber data on the (source) stack. > > I'm not altering the similar code in interrupt_entry() and nmi(), as > those code paths are unreachable afaict when running PV Xen guests. > > Fixes: 7f2590a110b837af5679d08fc25c6227c5a8c497 > Signed-off-by: Jan Beulich > Cc: stable@kernel.org Reviewed-by: Juergen Gross Juergen