Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 0/4] gcov: add Clang support
To:     Tri Vo <trong@android.com>
Cc:     ghackmann@android.com, ndesaulniers@google.com,
        linux-kernel@vger.kernel.org, kernel-team@android.com
References: <20190115183643.120619-1-trong@google.com>
From:   Peter Oberparleiter <oberpar@linux.ibm.com>
Date:   Wed, 16 Jan 2019 16:17:35 +0100
MIME-Version: 1.0
In-Reply-To: <20190115183643.120619-1-trong@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <65bb2ab8-4929-db7c-9d54-491d87ec23ae@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15.01.2019 19:36, Tri Vo wrote:
> From: Tri Vo <trong@android.com>
> 
> This patch series adds Clang supoprt for gcov.
> 
> Patch 1 refactors existing code in preparation for Clang support. Patches
> 2-3 implement necessary LLVM runtime hooks and gcov kernel interfaces.
> Patch 4 simplifies config selection.
> 
> Greg Hackmann (2):
>   gcov: clang: move common gcc code into gcc_base.c
>   gcov: clang support
> 
> Nick Desaulniers (1):
>   gcov: clang: link/unlink profiling data set.
> 
> Tri Vo (1):
>   gcov: clang: pick GCC vs Clang format depending on compiler

Overall this patch set looks good to me. It introduces a clean way for
GCC and Clang specific implementation details to coexist.

A quick test compile using GCC on s390 with the patch set applied was
successful, so it seems like the existing support is unaffected.

There are some detail suggestions on patch improvements that I'll post
in separate e-mails.

-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany