Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1525547imu; Wed, 16 Jan 2019 22:04:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN6qgE1thFHO3oq4MQ+VQArQnOZWh+/CMyhM1OXfdn+WfsVv2onYmr0+DBKpCEFlQycXqaEx X-Received: by 2002:a17:902:2ac3:: with SMTP id j61mr13680681plb.185.1547705054161; Wed, 16 Jan 2019 22:04:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547705054; cv=none; d=google.com; s=arc-20160816; b=XZOP/whOahbq9bPWhLt2FdXbHZSYLWLwsMDS6ZKRteyZq7j/Ohn7R+U43+JAwZJCU+ dIQZxIFA5xIzqTUGNGfdS/pBMmbvQTdNIRTyY6VwZwY8JbN630OTT8tTL7kLC/wnf1kU OTY/AN4WXa1wFj9gjDmQ2smpD2jYgMExyDCm0pSLINflPS5JmX0HiEjlFKUkSpHNWwlQ JM6EEZ9LPbVXJ/KEJoUwUmr5L6WBBIJ69nv8V8t887hq/t432MniBmH9LnFtNcgIL0E2 SRDAe22pN28tmWjwpuyrPBo8mxajqM7WLcdr+QdMIPNshrb6c1GVg+pjdN4yOgeeKpia iVAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=e5clcxMbHPA2lXWClRHnU06+keMu9ROnT0xU62I9Jcg=; b=k4vHccvW0jHHQXXseYTKuasjsctzEwXtm23rX334xLDpXa3uyeFs2RwMtOFpncvWEm ysyvgZu8t0Xmd85TBR3qWfBTXBVRAdkD4mQNYsxtujrEKYUT+zC1oSvsA95TptPCCPz3 agSDn77E5WVlTF4PAK/fMvmrfpoMARM2TF94H273bgmOXIRvb91OVmPkrGicIP4pThUm w3EuH9FvI5yIrHT88StaY/snvyNVxrOB07ftXAonh2X5CFImYybgL9sYcDj4s5jv2Ri0 FIh/dXCGrJvhgven+Hr7KmibGWL7m6pmxSlScIjlbQ12pEs8JuyGRla3JxVvCp/aJh+j a59g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=fJxhTiZj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c125si741353pfa.216.2019.01.16.22.03.57; Wed, 16 Jan 2019 22:04:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=fJxhTiZj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405821AbfAPQdg (ORCPT + 99 others); Wed, 16 Jan 2019 11:33:36 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:45238 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405717AbfAPQdd (ORCPT ); Wed, 16 Jan 2019 11:33:33 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0GGTGLe165658; Wed, 16 Jan 2019 16:32:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=e5clcxMbHPA2lXWClRHnU06+keMu9ROnT0xU62I9Jcg=; b=fJxhTiZjKS4yEoP26TvSGDrABJf5fnLpKWh+5Qt2MOEwEQv/NUmPKIapfyZUYgT1ebvS o5x5iCS7oJnALgQyAq1RFe5cN54P35vzvUgWQgO3rsruw2MPAXVuTYFM2r20AwRjWRCe PE9D3A8PZA7Uqh6oP7PyBHePQHz8yvxQkq+dQflBaaFvRv7DWCRbKFpgvP3M+dcC7kOf kSnLGIjOLA70UAZrp2U4ecXeJGK5c4DYgOrZ6c1BXpHephutWzfGttc6P6leOGXdam/y vTenF+VK5BbJ566uCNuk62fdXaozV4P25PA4i0/0Nvlr+/zoegDkKH1n6KCLn2JQ8cGH /w== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2pybkck0be-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Jan 2019 16:32:29 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x0GGWSsp023473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Jan 2019 16:32:29 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x0GGWSm2029923; Wed, 16 Jan 2019 16:32:28 GMT Received: from char.us.oracle.com (/10.152.32.25) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 16 Jan 2019 08:32:28 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id 24D4C6A0112; Wed, 16 Jan 2019 11:32:27 -0500 (EST) Date: Wed, 16 Jan 2019 11:32:27 -0500 From: Konrad Rzeszutek Wilk To: Dongli Zhang Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, roger.pau@citrix.com, paul.durrant@citrix.com Subject: Re: [Xen-devel] [PATCH v5 2/2] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront Message-ID: <20190116163227.GC7892@char.us.oracle.com> References: <1546935350-20957-1-git-send-email-dongli.zhang@oracle.com> <1546935350-20957-2-git-send-email-dongli.zhang@oracle.com> <5c3760a1-4f45-a67b-3b70-80fa68ee4358@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c3760a1-4f45-a67b-3b70-80fa68ee4358@oracle.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9138 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=863 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901160133 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 08, 2019 at 04:24:32PM +0800, Dongli Zhang wrote: > oops. Please ignore this v5 patch. > > I just realized Linus suggested in an old email not use BUG()/BUG_ON() in the code. > > I will switch to the WARN() solution and resend again. OK. Did I miss it?