Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1621262imu; Thu, 17 Jan 2019 00:07:49 -0800 (PST) X-Google-Smtp-Source: ALg8bN5Ykv3IgX6DRyAvRxQID/k2RDVF4Wi7BKWpb+XBJTd1Y+5QTZSoaTo6gmha7i+/sC3swVc0 X-Received: by 2002:a17:902:b592:: with SMTP id a18mr13978354pls.293.1547712469646; Thu, 17 Jan 2019 00:07:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547712469; cv=none; d=google.com; s=arc-20160816; b=mcUJoMXYjwYv50SlrsZbghjgiXnfqcXbl6TtIsthD7gW3klm+88Sw0tTz65El90M4V bncOBWe9myywN3IuCsxANCcXdDsIbFStLYlXM4kJrQo4iKvQhIC7JtGpaFCM+e1+WQBL psuLEAcMLheOg0GrLEWkqbYJPQ2oT8+2ZHMIMk3KK0Ho2Dqvu8j6gFCOhkWTtYxNbo8u 8nrbgndwfiBjCU8R6eUvzkebEZrEaNEpaiGruQf9A4sxIOF3Glr7VBMDDnThYJpoCzUh ewEhihxqVI6LsYyIYnQsT3ERy+Y1vO2Tb5bZ7D3AMWMB5PGqzq/44i1JWQT4gACwwpMc duGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:cc:to:subject:date:from :dkim-filter; bh=hmn4LVWeLn0M6M00DxndwCKoGpbnz+ffZKDPxJsth/k=; b=bVpDs1H8c3pEVeGU6D9kqprhrWvD95F9lpMlTLDyEH+3tdxsBT/MnzI6hf3TO6kg7z 3SlLf9oi/kQHmXncVFhAkkjDud81leJd6cgeN/HvecYT8ABDnCNGW/Vhw+5v+B1Z1Jt6 8gwDB5EXpDAd7N0RUec0b6psG1GtNCeZI0rcs/3QhJPbaV7CtE4t/z4H7PdFjihyjtlp MQoAWpij2NR23cqYGTGlnnN1QV1rRyzDddxmf9LltuEd/8vNSfrozlQuPjviK7glvgnA j3fR24dYc59Gsg3JpXsnrQVgDPgv1DvtgEzeRhQb2eS/1a9/Ng1PcjaEJmKE0F4h3Oxz Q5ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26si1027172pfi.184.2019.01.17.00.07.34; Thu, 17 Jan 2019 00:07:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732228AbfAPXEd (ORCPT + 99 others); Wed, 16 Jan 2019 18:04:33 -0500 Received: from mailgw1.fjfi.cvut.cz ([147.32.9.3]:45730 "EHLO mailgw1.fjfi.cvut.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728639AbfAPXD7 (ORCPT ); Wed, 16 Jan 2019 18:03:59 -0500 Received: from localhost (localhost [127.0.0.1]) by mailgw1.fjfi.cvut.cz (Postfix) with ESMTP id 830A9B0433; Wed, 16 Jan 2019 23:55:47 +0100 (CET) X-CTU-FNSPE-Virus-Scanned: amavisd-new at fjfi.cvut.cz Received: from mailgw1.fjfi.cvut.cz ([127.0.0.1]) by localhost (mailgw1.fjfi.cvut.cz [127.0.0.1]) (amavisd-new, port 10022) with ESMTP id At6GMvediolp; Wed, 16 Jan 2019 23:55:43 +0100 (CET) Received: from linux.fjfi.cvut.cz (linux.fjfi.cvut.cz [147.32.5.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailgw1.fjfi.cvut.cz (Postfix) with ESMTPS id 913E1AFD58; Wed, 16 Jan 2019 23:55:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailgw1.fjfi.cvut.cz 913E1AFD58 Received: by linux.fjfi.cvut.cz (Postfix, from userid 1001) id 740856004E; Wed, 16 Jan 2019 23:55:42 +0100 (CET) From: Jonas Rabenstein Date: Mon, 19 Mar 2018 19:36:47 +0100 Subject: [PATCH 08/16] block: sed-opal: print failed function address To: Jens Axboe , Scott Bauer , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonas Rabenstein Message-Id: <20190116225542.740856004E@linux.fjfi.cvut.cz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add function address (and if available its symbol) to the message if a step function fails. Signed-off-by: Jonas Rabenstein --- block/sed-opal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index 1332547e5a99..4225f23b2165 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -394,8 +394,8 @@ static int next(struct opal_dev *dev) error = step->fn(dev, step->data); if (error) { - pr_debug("Error on step function: %d with error %d: %s\n", - state, error, + pr_debug("Step %d (%pS) failed wit error %d: %s\n", + state, step->fn, error, opal_error_to_human(error)); /* For each OPAL command we do a discovery0 then we -- 2.20.1