Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1621290imu; Thu, 17 Jan 2019 00:07:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN4AudSUKuPl7z/4qSeA5pNu/W7NfhQH21MJXaSBmbZoscMfuXT0ApNhozvxCfaoYtfZJ6jj X-Received: by 2002:a62:1c7:: with SMTP id 190mr13999522pfb.46.1547712472085; Thu, 17 Jan 2019 00:07:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547712472; cv=none; d=google.com; s=arc-20160816; b=R7bFj9uuEpDmhRG8X8rOmj8vaae3Xw/bwhBBHZrgaT1g0RBFr/uirWQWGAICz1hkr7 /TRVirIb7jd24ZYa2bKR/eOYaRkcSAfmnzeg9xTol2U56jwMAHFWClQd0tUh/QHhP3TH r6XIuaxyfeE9ytP21fJMHTLSQNexB2eSSgF+35mV3Yxq67WQF1XOD9DfuZBjhae9OdRU /x4x/RQyYEIrnPTNdY/A0FOvNmQeOtNSwnVh1bfPOPoFlU1gZ7gKTmnSKHBIKqZ2e5r+ y1mR5TSUSafyae1stXgycYNgHaJfVc7gL29wbPgcANRxa2h7YKLs06jCKnf2gWOLdVkF ykbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:cc:to:subject:date:from :dkim-filter:dkim-signature; bh=UBxIMAPDODPNIQgGigLkcRAIWQR7DtqhIBTjJHo7StA=; b=zjN6xQAA4Mvt0Btq3LMBoVvhHus1ZhEswnZdCGrcNwSue4V1gKOUdkMTBlwtenHKqK /L3ST2xM2EP8yZd3twrSxhBt7ZvtZNVECybHhjnFMZagU/nzE0GsMXlCXNQZplsQb5rq wPNphG85ZeSM3CUKXbfdDncCen1321w1EqIUXJczqt+210yABPkSHARZ/UpDbjwQfLEp QKZnaoxa2YEu/ynz1zRTeN9ujPuG/Z7YGnz1u8cCIgDg3v59z5xho6lahdo87rVdWSjA svYZwknpQP5zfle/koE9HlA7+fxKhxUBeW1LMYrBRF8cAEmZx5pr0d6lhjdWqF+5pWh5 nJfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fjfi.cvut.cz header.s=20151024 header.b=kkaL5lMA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d36si1065013pla.216.2019.01.17.00.07.36; Thu, 17 Jan 2019 00:07:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fjfi.cvut.cz header.s=20151024 header.b=kkaL5lMA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387759AbfAPXFL (ORCPT + 99 others); Wed, 16 Jan 2019 18:05:11 -0500 Received: from mailgw1.fjfi.cvut.cz ([147.32.9.3]:45700 "EHLO mailgw1.fjfi.cvut.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbfAPXD4 (ORCPT ); Wed, 16 Jan 2019 18:03:56 -0500 Received: from localhost (localhost [127.0.0.1]) by mailgw1.fjfi.cvut.cz (Postfix) with ESMTP id E7883AE0C6; Wed, 16 Jan 2019 23:55:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fjfi.cvut.cz; s=20151024; t=1547679337; i=@fjfi.cvut.cz; bh=UBxIMAPDODPNIQgGigLkcRAIWQR7DtqhIBTjJHo7StA=; h=From:Date:Subject:To:Cc; b=kkaL5lMAJeo6xdUy3g3F4ethNBTwuC+HT1EnH9jdYAsOAzzHKBtX41Tfittv96Gye e4VP+e+fERd6oyA+UkxoxsNCAj38BFyB9NfJtP/E9FHmDRgnhcYoI0BdS3Og6bCEIC nxZ4EMTjIgCxBZ3+3aJqoYxBNsBu9kUznYLrX8uY= X-CTU-FNSPE-Virus-Scanned: amavisd-new at fjfi.cvut.cz Received: from mailgw1.fjfi.cvut.cz ([127.0.0.1]) by localhost (mailgw1.fjfi.cvut.cz [127.0.0.1]) (amavisd-new, port 10022) with ESMTP id zl1W4sOpkHIQ; Wed, 16 Jan 2019 23:55:35 +0100 (CET) Received: from linux.fjfi.cvut.cz (linux.fjfi.cvut.cz [147.32.5.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailgw1.fjfi.cvut.cz (Postfix) with ESMTPS id 03EA9ADF0E; Wed, 16 Jan 2019 23:55:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailgw1.fjfi.cvut.cz 03EA9ADF0E Received: by linux.fjfi.cvut.cz (Postfix, from userid 1001) id D1B586004E; Wed, 16 Jan 2019 23:55:34 +0100 (CET) From: David Kozub Date: Sat, 5 Jan 2019 22:23:56 +0100 Subject: [PATCH 01/16] block: sed-opal: fix typos and formatting To: Jens Axboe , Scott Bauer , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonas Rabenstein Message-Id: <20190116225534.D1B586004E@linux.fjfi.cvut.cz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This should make no change in functionality. The formatting changes were triggered by checkpatch.pl. Signed-off-by: David Kozub --- block/sed-opal.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index e0de4dd448b3..c882a193e162 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -11,8 +11,8 @@ * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * for more details. */ #define pr_fmt(fmt) KBUILD_MODNAME ":OPAL: " fmt @@ -157,7 +157,7 @@ static const u8 opaluid[][OPAL_UID_LENGTH] = { /* C_PIN_TABLE object ID's */ - [OPAL_C_PIN_MSID] = + [OPAL_C_PIN_MSID] = { 0x00, 0x00, 0x00, 0x0B, 0x00, 0x00, 0x84, 0x02}, [OPAL_C_PIN_SID] = { 0x00, 0x00, 0x00, 0x0B, 0x00, 0x00, 0x00, 0x01}, @@ -623,7 +623,7 @@ static int build_locking_range(u8 *buffer, size_t length, u8 lr) static int build_locking_user(u8 *buffer, size_t length, u8 lr) { if (length > OPAL_UID_LENGTH) { - pr_debug("Can't build locking range user, Length OOB\n"); + pr_debug("Can't build locking range user. Length OOB\n"); return -ERANGE; } @@ -1324,6 +1324,7 @@ static int start_SIDASP_opal_session(struct opal_dev *dev, void *data) if (!key) { const struct opal_key *okey = data; + ret = start_generic_opal_session(dev, OPAL_SID_UID, OPAL_ADMINSP_UID, okey->key, @@ -1341,6 +1342,7 @@ static int start_SIDASP_opal_session(struct opal_dev *dev, void *data) static int start_admin1LSP_opal_session(struct opal_dev *dev, void *data) { struct opal_key *key = data; + return start_generic_opal_session(dev, OPAL_ADMIN1_UID, OPAL_LOCKINGSP_UID, key->key, key->key_len); @@ -1714,7 +1716,7 @@ static int lock_unlock_locking_range(struct opal_dev *dev, void *data) write_locked = 0; break; case OPAL_LK: - /* vars are initalized to locked */ + /* vars are initialized to locked */ break; default: pr_debug("Tried to set an invalid locking state... returning to uland\n"); @@ -1775,7 +1777,7 @@ static int lock_unlock_locking_range_sum(struct opal_dev *dev, void *data) write_locked = 0; break; case OPAL_LK: - /* vars are initalized to locked */ + /* vars are initialized to locked */ break; default: pr_debug("Tried to set an invalid locking state.\n"); @@ -2222,7 +2224,7 @@ static int __opal_lock_unlock(struct opal_dev *dev, static int __opal_set_mbr_done(struct opal_dev *dev, struct opal_key *key) { u8 mbr_done_tf = 1; - const struct opal_step mbrdone_step [] = { + const struct opal_step mbrdone_step[] = { { opal_discovery0, }, { start_admin1LSP_opal_session, key }, { set_mbr_done, &mbr_done_tf }, @@ -2273,7 +2275,8 @@ static int opal_take_ownership(struct opal_dev *dev, struct opal_key *opal) return ret; } -static int opal_activate_lsp(struct opal_dev *dev, struct opal_lr_act *opal_lr_act) +static int opal_activate_lsp(struct opal_dev *dev, + struct opal_lr_act *opal_lr_act) { const struct opal_step active_steps[] = { { opal_discovery0, }, -- 2.20.1