Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 17 Jan 2019 02:05:09 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Jonathan Neuschafer <j.neuschaefer@gmx.net>,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        stable@vger.kernel.org
Subject: Re: [RESENDING PATCH] powerpc/wii: properly disable use of BATs when
 requested.
Message-ID: <20190117010509.GH22334@latitude>
References: <7e6748349978f4f177b6a1f3f1c773da98ae3b59.1547570012.git.christophe.leroy@c-s.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ulDeV4rPMk/y39in"
Content-Disposition: inline
In-Reply-To: <7e6748349978f4f177b6a1f3f1c773da98ae3b59.1547570012.git.christophe.leroy@c-s.fr>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ulDeV4rPMk/y39in
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi again,

On Tue, Jan 15, 2019 at 04:43:20PM +0000, Christophe Leroy wrote:
> 'nobats' kernel parameter or some options like CONFIG_DEBUG_PAGEALLOC
> deny the use of BATS for mapping memory.
>=20
> This patch makes sure that the specific wii RAM mapping function
> takes it into account as well.
>=20
> Fixes: de32400dd26e ("wii: use both mem1 and mem2 as ram")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
[...]
>  	/* MEM2 64MB@0x10000000 */
>  	delta =3D wii_hole_start + wii_hole_size;
> +	if (__map_without_bats)
> +		return delta;
> +

Nothing is visibly broken without this patch, even with
CONFIG_DEBUG_PAGEALLOC (tested on top of v5.0-rc2), but the patch still
looks correct.

I'd prefer the 'if' block to be before the whole delta/size calculation,
to make the code slightly more readable because the delta and size
calculations stay in one visual block. It doesn't need to happen after
delta is calculated.

tentatively,
Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>


Thanks,
Jonathan

--ulDeV4rPMk/y39in
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAlw/1LwACgkQCDBEmo7z
X9t15w/9HAIpyLsvt8vSwK4gfTd5obM3aiOswCoMWl5NJty0FA0ptb8htS29OHfe
vvJ99HXuAh7Mg+2wtXIwqNZs7lk1EVT6N80ORj4LP7xQCzxR1q6BWaWPmSDjTtQw
aeub/Px9Ldb7Ynglqys4fnsEi9MWUVYa++WvZ5s8UOMk6wRfxOIItUvSnOwVgATG
KvXc7t1OJsJbgU+Goay6HggyQNmk4G9asv+OtD+hVazDpHiEOeQYweGLlQ2/lgjI
MaEZ7FRZLqqBjTviCXkLLUJ5wkR9+Q6wioDU9ss1eHczuZinfUDoY5LYnj3oqOwn
vLiC+HbaV2yniS6CHRLXEyonnBzVX0MHTjSiQRmfZBbX2rAaXrQbV/JUztswA/3A
KcDERzAr2R1ZUgp8aNELQQJC5n3BhCutXJ/CndsDkqrQq5FJOEpfmuUmoJYvf+1q
vkrLmezvcrlcgPn2H4iDi/986BAGvJNdPq0cN8x2qusn1Onb1JM7HeyNC06JR3BM
ILCTpmpDm2lKkEL0lbFSACeIvFcuQk2A/778w/RT9Z3WN4NONthnObD79h2RFNQu
1XmWMLgIyjTrOl5zDITwa6LsleEkDeIQo7h+3qdbytDXQAMHQhsz8nJNDh6kL6kT
o8lhk28kHVMQGiGtp1M8VJBdW1KctUKwBOuprSAtJts9x8YPiYE=
=ftf9
-----END PGP SIGNATURE-----

--ulDeV4rPMk/y39in--