Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     "Winkler, Tomas" <tomas.winkler@intel.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        "Hunter, Adrian" <adrian.hunter@intel.com>
CC:     Christoph Hellwig <hch@lst.de>,
        Vivek Gautam <vivek.gautam@codeaurora.org>,
        Subhash Jadavani <subhashj@codeaurora.org>,
        Alex Lemberg <Alex.Lemberg@wdc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: ufs: revamp string descriptor reading
Thread-Topic: [PATCH] scsi: ufs: revamp string descriptor reading
Thread-Index: AQHUkToZe4SsRaGsKUGoSCcHYz8eo6V5tOmggANuPoCANi0vAIAABlzg
Date:   Thu, 17 Jan 2019 08:14:54 +0000
Message-ID: <SN6PR04MB492505EFD15BB09BDC0A4D80FC830@SN6PR04MB4925.namprd04.prod.outlook.com>
References: <20181211110705.11646-1-tomas.winkler@intel.com>
 <DM6PR04MB4923D16D47784A1750811A19FCA60@DM6PR04MB4923.namprd04.prod.outlook.com>
 <5B8DA87D05A7694D9FA63FD143655C1B9DA525B5@hasmsx108.ger.corp.intel.com>
 <5B8DA87D05A7694D9FA63FD143655C1B9DA7C91D@hasmsx108.ger.corp.intel.com>
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9DA7C91D@hasmsx108.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c3dc87c-cbaf-4d72-c151-08d67c53dcb9
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2019 08:14:54.5734
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4688
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> > > Hello Tomas,
> > >
> > > >
> > > > Define new a type: uc_string_id for easier string handling and less
> > > > casting. Reduce number or string copies in price of a dynamic
> > > > allocation.
> > > >
> > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > Tested-by: Avri Altman <avri.altman@wdc.com>
> > >
> > > Just one nit - doesn't really matters.
> > >
> > > Cheers,
> > > Avri
> > >
> > > > ---
> > > >  drivers/scsi/ufs/ufs-sysfs.c |  20 ++---
> > > >  drivers/scsi/ufs/ufs.h       |   2 +-
> > > >  drivers/scsi/ufs/ufshcd.c    | 164 +++++++++++++++++++++----------=
----
> > > >  drivers/scsi/ufs/ufshcd.h    |   9 +-
> > > >  4 files changed, 115 insertions(+), 80 deletions(-)
> > >
> > >
> > > >
> > > >  	ufs_fixup_device_setup(hba, &card);
> > > > +	ufs_put_device_desc(&card);
> > > ufs_get_device_desc() and ufs_put_device_desc() actually serves the
> > > quirks setup.
> > > Make sense to call it from within so the logic is clear and in one pl=
ace.
> > > Might also save ufs_put_device_desc().
> >
> > You are right from the current perspective , just I'd need it also for =
the
> RPMB
> > patches that should follow, then it will have bit larger span than the =
quirks.
> >
>=20
> Is this okay, can we merge?
Looks good to me.

Thanks,
Avri

> Thanks
> Tomas