Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1705869imu; Thu, 17 Jan 2019 01:48:06 -0800 (PST) X-Google-Smtp-Source: ALg8bN6m67lGCjK5676nz/LiHXK75OZP6nXCyGh+QQp8Yqd/LI+YBjKpWHLCWsgTgLxzGyBHJAAV X-Received: by 2002:a17:902:ab92:: with SMTP id f18mr13802051plr.221.1547718485970; Thu, 17 Jan 2019 01:48:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547718485; cv=none; d=google.com; s=arc-20160816; b=hrGx+JYWsQXFPTEcjTiH5Trzb02VuHbzHHv/R934bTnLoRXHnM2MsIKntS/BVJolk7 e/8HGV0bT7vC8AXJuhlBJn5KUEaoYuXPTTd2YRYtBAQ7lA0MA3qwBzz9OhMC68bvcpFd zKiLojTvHhGlD4RwhDYcviqoBwCsgCSigdTBS0XqkkL6rNJQn9lYZ7g6hRMWSxgR430o FWC3P7Xz9spsstlbcsBMMGVKA0xW3SMwBXDTWkidXLGxLjcayGOplW3fWMLbadoLKH6t bogq1YX+8XtheuoVQNVs7v6D2Yknu2IrZtibJn4Oa+SWT0b9g3IUh83/fxdD8+wtTNEo l0Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UYghhEZQHP1Qcov3H6YoxMTXD6MNF89VmqkskXE7lI4=; b=epFMLYBECqP6i5cbtlbQ5XWYNLqrXnDpzLEa1Ep/xlO1HLLjFiAE1jkegj67M2pV01 1L8X5kd0dUCCjLHh10iGcZOUiNrqyizzWtxymsUJsgWxk8ug7f5EplGJH3zEjPFsoqFr bQ8q0wjdC6b1hHynEgEVCOKua3QDFRrgEI7bwAfKCF+Uk/y3IcRVmzIwD5rbFIbXZB2E YwZFCPN+HH+99DSO4x1Vf1Nx9o/1Ku4BJGLSBrH0FiRowlSHVTBB9axwViUv+Ey/FRXt mpLY08ySIn2mlJCUhJOlwYehyIc9V6IKElpuQ1PrE0xorsYktA2GH4a61PPBmSNVz/HO 9DAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q73si1225309pfi.205.2019.01.17.01.47.50; Thu, 17 Jan 2019 01:48:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbfAQJMK (ORCPT + 99 others); Thu, 17 Jan 2019 04:12:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:44710 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726926AbfAQJMJ (ORCPT ); Thu, 17 Jan 2019 04:12:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9C488AC9C; Thu, 17 Jan 2019 09:12:08 +0000 (UTC) Date: Thu, 17 Jan 2019 10:12:08 +0100 From: Petr Mladek To: Miroslav Benes Cc: jpoimboe@redhat.com, jeyu@kernel.org, jikos@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Periodic fake signal Message-ID: <20190117091208.3zzdgvjxyf5huoey@pathway.suse.cz> References: <20190115164507.14676-1-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190115164507.14676-1-mbenes@suse.cz> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2019-01-15 17:45:05, Miroslav Benes wrote: > I somehow forgot about this patch set. The discussion about v1 was > inconclusive, so I'm sending it again with changes according to the > feedback I got. I still think it is useful, so please consider. > > Changes since v1: > - timeout changed to 15 seconds (Josh) > - make it wait for 15 seconds, no more, no less (Josh) > - the message in klp_send_signals() is printed only once per transition > (Josh) > - the counter is zeroed in klp_start_transition(), so that even > klp_reverse_transition() starts correctly (Petr) > > Miroslav Benes (2): > livepatch: Send a fake signal periodically > livepatch: Remove signal sysfs attribute Both patches look fine to me: Reviewed-by: Petr Mladek Best Regards, Petr