Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1712151imu; Thu, 17 Jan 2019 01:56:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN4oQw4wlF18v6+oHUGzRUzvtdndHmnjP5xFnA4o3bXtV24vy5towVuXQSHhXPuNCv+vHosO X-Received: by 2002:a65:6094:: with SMTP id t20mr12781804pgu.285.1547718964519; Thu, 17 Jan 2019 01:56:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547718964; cv=none; d=google.com; s=arc-20160816; b=P08BuX4yEAyCqaZ00aIhNGd+BZH21VaQ8aWOFntdb6GJjvN1gTaT9xCQjM3gwaJxyI 1PQs9l0aXByLQKThoNbh5OO/+6anmRz95Y5fTrUXr6UKluaKJt6idFAZ+im/p7+8+ktA PS+54yM38qUZIYmUu+aoaN2YbBPr8orMZHpnLNp92l4I5xmRNbfp7HzlJA0ftyyMtfvA CEsuPLdXm7zxnz4UtCeTPK3wa5nGYoE1bqUOW96AVI1ztabf86jggJXr7dran26eQsfA DLeWJMv++dtw3Py+ltO+jLjG5TGNbY2IepMoa8YK//fmNlmLW+D1M9LwwgRxbmGszK1M i40w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=V93pEPVPfkotgo/EzGgOwG8g/w8ZJu14onK+Wr/3Y+Y=; b=r+t3bnw0wXkr9S6VxGmhdE3CMBrjygB5Q2hHCEfAEyN093khapAbz3vmWzK7mkV9Rc Qkv0jkkuH1O8G9X5gTqrhk5uVU3D3+TyKN/jfy5k68i8KLh97LY0Aw+ZcQE+/RoB9ttq 7luUG7kxBiLD0PgRV7W9rSYpA88OKzEkHVWjIdDkjUNXlsdLwVqKZHCbNkN565xevezJ wCpti4mfTgmQPhplmBjIxxx8UmBX3KVzfr0EkojkAZVNo2Q8ZSwTFiIEwRzP4asGoisf wtJac5fG7tkTcxm1UOBve+1b8WjKj7XxlyFBiu+5lCoJR4l+iXWji0sE4T2gnlG/1CKm 7XGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k12si1154028pgg.382.2019.01.17.01.55.49; Thu, 17 Jan 2019 01:56:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbfAQJyi (ORCPT + 99 others); Thu, 17 Jan 2019 04:54:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:59266 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725965AbfAQJyi (ORCPT ); Thu, 17 Jan 2019 04:54:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9BE55ABCE; Thu, 17 Jan 2019 09:54:36 +0000 (UTC) Date: Thu, 17 Jan 2019 10:52:03 +0100 From: Cyril Hrubis To: Jiri Kosina Cc: Matthew Wilcox , Linus Torvalds , Dominique Martinet , Andy Lutomirski , Josh Snyder , Dave Chinner , Jann Horn , Andrew Morton , Greg KH , Peter Zijlstra , Michal Hocko , Linux-MM , kernel list , Linux API Subject: Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged Message-ID: <20190117095203.GA23942@rei.lan> References: <9E337EA6-7CDA-457B-96C6-E91F83742587@amacapital.net> <20190116054613.GA11670@nautica> <20190116213708.GN6310@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Your patch 3/3 just removes the test. Am I right in thinking that it > > doesn't need to be *moved* because the existing test after !PageUptodate > > catches it? > > Exactly. It just initiates read-ahead for IOCB_NOWAIT cases as well, and > if it's actually set, it'll be handled by the !PageUpdtodate case. > > > Of course, there aren't any tests for RWF_NOWAIT in xfstests. Are there > > any in LTP? > > Not in the released version AFAIK. I've asked the LTP maintainer (in our > internal bugzilla) to take care of this thread a few days ago, but not > sure what came out of it. Adding him (Cyril) to CC. So far not much, I've looked over our mincore() tests and noted down how to improve them here: https://github.com/linux-test-project/ltp/issues/461 We do plan to test the final mincore() fix: https://github.com/linux-test-project/ltp/issues/460 And we do have RWF_NOWAIT tests on our TODO for some time as well: https://github.com/linux-test-project/ltp/issues/286 I guess I can raise priority for that one so that we have basic functional tests in a week or so. Also if anyone has some RWF_NOWAIT tests already it would be nice if these could be shared with us. [A bit off topic rant] I've been telling kernel developers for years that if they have a test code they used when developing a kernel feature that they should share it with us (LTP community) and we will turn these into automated tests and maintain them for free. LTP is also used in many QA departements around the word so such tests will end up executed in different environments also for free. Sadly this does not happen much and there are only few exceptions so far. But maybe I wasn't shouting loudly enough. -- Cyril Hrubis chrubis@suse.cz