Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1735471imu; Thu, 17 Jan 2019 02:21:13 -0800 (PST) X-Google-Smtp-Source: ALg8bN7oFlOuXRjzaphVU3a2LsaeLEy4nfcG7xTPHHu2AScoyHNNSMe841HRnORrestPzJgxj1vA X-Received: by 2002:a17:902:2006:: with SMTP id n6mr14604282pla.66.1547720473559; Thu, 17 Jan 2019 02:21:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547720473; cv=none; d=google.com; s=arc-20160816; b=xQYbcRDkGhbk/4/CZs6PBDIfb9zsKqgoSHzyLTOsgRuHQAKDAcWtTiZTywIITYPNpY ukTjYB0vJcf2qCMeJcO6Cw/U2p4olwTFvmprD8yq8j7LV9i8AjxO7e2egdj8jIqXYL08 XTb9EdsHgFptfMS8ou556ThsJb7g6KRqeln/BfAeWP9wgM3rE/8DhTCQcVi8siNO9ewC I3ZP+57ODYvAS8/an1R7+/FfCrf8TQcrVm1DQx7/wRaZsULxW4HW3ICZKELAuBiVTQmO l6Xey0QWM+1lYLeJQnpoOHWVYbMKIY/AOs6p5uMY8Mn2hx9WaXpyHhudwCJhD3czKlhk oU8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=FdD+tfeB95Rqy4UfXmfRkY/80328GdayO5ZQelHfPHY=; b=QOX2SA6hkXUri17KHeRLUqL1t7WG1S5ns2Rkokdk0+h3KoXhk95qxLut3bQN3dXGmZ ag5LVUrh+rBqZKecvH0csRzx3xgPF2wDGGgSv8KmXkkVNmY+70UHFSuO7m55O+tE44S4 p0lcwkMJ9OLJjZFlDWJQnOGX/E66iwfh9iJFQ8oOo7MvLnY86UYArczxWfuHm2dX+7wc ShRXdCevcdRBxQxzolEc8Sg5lWX+2XWmU0I4aGyffLX8unnlg47FIiRainLiDHtobbMX 5GekN2qC+gRLi+fiLgh+jPwXEWux6E/OfVl/DE96YfIXPh+2qlBQLRem8cnpnpQgsr2k u0PA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=oCd+VtK+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92si1291415plw.158.2019.01.17.02.20.54; Thu, 17 Jan 2019 02:21:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=oCd+VtK+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727376AbfAQKTm (ORCPT + 99 others); Thu, 17 Jan 2019 05:19:42 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:49308 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfAQKTl (ORCPT ); Thu, 17 Jan 2019 05:19:41 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0HAJ2VY133468; Thu, 17 Jan 2019 10:19:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=FdD+tfeB95Rqy4UfXmfRkY/80328GdayO5ZQelHfPHY=; b=oCd+VtK+UzT5Mm8ons8XKW9UVskFM5nIxvc7VlwE+JnHYumSXX7lWpEnI6uQMWFzlPXl uhXa7MrIbARWLAL3RZbnZHvUpeWNvi611iMbWCQBgO2BWD+bFd/CFW9otbvWTy9ywnQ4 VuizWiyid+hNHQe5vwI60xCZBTU0z5p25eYBzt+dv+/gjQPSgczPdjW65IeCXUU/fHYU XKDOyO7cRFfBgg/UYgHtUEegrnDMR+90sH99YUgGv1Y8KD6jlemVFbKW0Vp4P2h+HcOG zkhdYl0xpcvAVQcHOkZ2PlgjRyL1aDHVuw8jdxMQ/PEkn1dSnarUfYm/AbHmya+HVAyZ Ww== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2130.oracle.com with ESMTP id 2pybjny1p8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jan 2019 10:19:37 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x0HAJbPM031189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jan 2019 10:19:37 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x0HAJaK9012213; Thu, 17 Jan 2019 10:19:36 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 17 Jan 2019 02:19:36 -0800 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH] mm/page_alloc: check return value of memblock_alloc_node_nopanic() From: William Kucharski In-Reply-To: <1547621481-8374-1-git-send-email-rppt@linux.ibm.com> Date: Thu, 17 Jan 2019 03:19:35 -0700 Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <5195030D-7ED9-4074-AB6C-92A3AFF11E00@oracle.com> References: <1547621481-8374-1-git-send-email-rppt@linux.ibm.com> To: Mike Rapoport X-Mailer: Apple Mail (2.3445.102.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9138 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901170076 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This seems very reasonable, but if the code is just going to panic if = the allocation fails, why not call memblock_alloc_node() instead? If there is a reason we'd prefer to call memblock_alloc_node_nopanic(), = I'd like to see pgdat->nodeid printed in the panic message as well.