Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Message-ID: <e2e064f2-e8ef-42ca-bf4f-76b612964752@default>
Date:   Thu, 17 Jan 2019 02:10:59 -0800 (PST)
From:   Zhenzhong Duan <zhenzhong.duan@oracle.com>
To:     <linux-kernel@vger.kernel.org>
Cc:     <mingo@redhat.com>, <konrad.wilk@oracle.com>, <tglx@linutronix.de>,
        <dwmw@amazon.co.uk>, <bp@suse.de>, <srinivas.eeda@oracle.com>,
        <peterz@infradead.org>, <hpa@zytor.com>
Subject: [PATCH] x86/speculation: Remove redundant arch_smt_update() call in
 sysfs SMT control
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

With commit a74cfffb03b7 ("x86/speculation: Rework SMT state change"),
arch_smt_update() is invoked from each individual CPU hotplug function.
Then the extra arch_smt_update() call in the sysfs SMT control is
redundant.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
 kernel/cpu.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 91d5c38..c0c7f64 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -2090,10 +2090,8 @@ static int cpuhp_smt_disable(enum cpuhp_smt_control =
ctrlval)
 =09=09 */
 =09=09cpuhp_offline_cpu_device(cpu);
 =09}
-=09if (!ret) {
+=09if (!ret)
 =09=09cpu_smt_control =3D ctrlval;
-=09=09arch_smt_update();
-=09}
 =09cpu_maps_update_done();
 =09return ret;
 }
@@ -2104,7 +2102,6 @@ static int cpuhp_smt_enable(void)
=20
 =09cpu_maps_update_begin();
 =09cpu_smt_control =3D CPU_SMT_ENABLED;
-=09arch_smt_update();
 =09for_each_present_cpu(cpu) {
 =09=09/* Skip online CPUs and CPUs on offline nodes */
 =09=09if (cpu_online(cpu) || !node_online(cpu_to_node(cpu)))
--=20
1.8.3.1