Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1872696imu; Thu, 17 Jan 2019 04:48:58 -0800 (PST) X-Google-Smtp-Source: ALg8bN6/9C+u2frSL47MzT/gh+OrDU0lTWNK5zKAGjKsjAQlQypwUqsdPFDO6apDxnHv6TODdh63 X-Received: by 2002:a63:ab08:: with SMTP id p8mr13067269pgf.87.1547729338767; Thu, 17 Jan 2019 04:48:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547729338; cv=none; d=google.com; s=arc-20160816; b=RVB7yDuYbfYjH1eEeT7Gsb3u27sRabmQxrzguyj85/QxPo9g1RAYAPZit6Gs1wF0FH dqisXOREwHxRI71CgF6llDDb4X/nxZ95yCC/zDUheUiwJuPGR45o3A2ckpZxQcOMM//g R0EDuH2nlWTyGdnVCuIO+wO8HvKZd8dANWKfRkseq6NreJJ2Hb57rK7l9y87SgIhCDdp i9DnGqalcKdu6EfRZWR8LZnvysWoxchppuTkbMMeyB86XvlodILAFqxU8MkfIXxqWbRv we6vzacmCzsZTKWnHiKVObb5W+7OIva4fJgt9bPMTwaZa/J/p2FfD7yv6bse2yfdUVjy CRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Voh4uiO/wHtnQ1WFQQgoyKfQWT7MoI/Wue40o0x/Eqc=; b=k1yRNLjmSFJUN+TgtIqKlx31IVY+B2EsQApYc3baED2iG1D+lTPf71HhdJfwCsGVAm x4ZlTBbdo6tQtRhWTkxgNIK5zRLKKvMoS0zpMAyBx6BC+b+i5aGTAcRukk6yhSC3kqKT 7NlnUMeagLaRLV+QNvN+UbH7mJCDzisyhS60ZWH9mVlycdTsP/te2ZR0Uz15bKeGmtXf 906epYl6y8t9zniH0tyFHXj32RsZMYAUlYeTQsUXeVTK23XUNc8wAIJHpXFOXF10OdOP rPobYf+0HhHsm3WMTM2/uBy39d9PTE/AVjLInrqUJTT/oJ7S09+3nDdORLnbCxEMVQm3 mDzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JvGqybcp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 204si331780pfu.273.2019.01.17.04.48.43; Thu, 17 Jan 2019 04:48:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JvGqybcp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726031AbfAQLqO (ORCPT + 99 others); Thu, 17 Jan 2019 06:46:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:37956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbfAQLqO (ORCPT ); Thu, 17 Jan 2019 06:46:14 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2088520657; Thu, 17 Jan 2019 11:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547725573; bh=wQcJbbzDehn3t4lSTi/uSgaHCnpmLLsEu/tQlw29y4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JvGqybcpSt/eLZpDFQ3LB28sbSVbKTWCL09vYwIx6xNsqsjdpy0dqpP2g9NfYzjly HfFui0KpZ5AA3/EV6ZII1/IkY9HoPc+sFQHVo9bWbGvkmpolwpKRgRIxAFblDLpPNt bOS1qv4T1NfpLuLjTdncy9NP4aPkAjrD8wPFcC0s= Date: Thu, 17 Jan 2019 12:46:10 +0100 From: Greg Kroah-Hartman To: Robert O'Callahan Cc: "Eric W. Biederman" , LKML Subject: Re: Regression in 32-bit-compat TIOCGPTPEER ioctl due to 311fc65c9fb9c966bca8e6f3ff8132ce57344ab9 Message-ID: <20190117114610.GB2430@kroah.com> References: <87won67580.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 08:36:49AM +1300, Robert O'Callahan wrote: > On Tue, Jan 15, 2019 at 8:25 PM Eric W. Biederman wrote: > > Can you confirm this fixes it for you? > > Sorry --- I made a mistake. It looks like this is already fixed on > master, by commit e21120383f2dce32312f63ffca145ff8a87d41f5 (though I > don't think Al Viro knew he was fixing this bug). So, nothing to do > here. As you found a regression from 4.13 - 4.19, shouldn't we backport some fix to the 4.14 and 4.19 kernels for this? thanks, greg k-h