Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1890649imu; Thu, 17 Jan 2019 05:06:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN6E8nWjewF6hWPnfCHQrXRTo/R+Xd+LqQPL2nHzy/cmHgl2Jc//x26ZUSCMHk+vUujlOeoB X-Received: by 2002:a62:26c7:: with SMTP id m190mr15050598pfm.79.1547730401916; Thu, 17 Jan 2019 05:06:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547730401; cv=none; d=google.com; s=arc-20160816; b=kwZHkbdA2FaYGoB1NcavVg+SM4xp5kIjUG/UrNtPDrD8bWCtQvmFxIwCPv2sVBDqwg 8WLz1TXb6keDLPNY06YKJQ/MFatki2hFDmf6wl6Vm74hMD4GZ5DzUMZOzpJBOnHi6dvT Ds5oKRYQd7fy6/CvHLs0fIfpjxSW/0tcN6x4UgYKuN67PXedduFRN/DRHbQ9Q3GT/6qx hBJxnEv+/9hvV+Txl3WA97B4N7sip/auZto5pjS5nlDRPw+aOPCOcz3Zn2ss9NgBX7+d nMz70AFHFQtVkyKia9EyyeFs0oydcLIoYkcsrpqy2yA3haj7Ua3orBitNb5eGTkfOxaN QOXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=5R2gam73YceTw8kE+bPAERTYZIsjaBlY2vxjhSpEStE=; b=TXwEeCeWWiogqWDQqfdz4ABGy5+/zcDov3pSCKokFJAo79YRwneZgtURlJ64jB3UwD y8L0a9CAbBx8/rAXLiT8TsMj+g04AIfKNzYb29GwlLvsLoQTT7iXC6SB50yZVkpobuNS bZPpR5S43z+flxcLp3FhWVCvJ6GffuIg9LwNeDvkUO6yu1vWSHPwy2gMAzSPniVkc72z VTLVKXGBXnO2FS0ZyEVtJPKByfKDldKDKkInHMqzCXSvOrALENEsVXnY6tbllcYCFQh7 UVrmcVT6+3IsSEegd06Mg2qbzEfZQn+LYK38t6Sd5o4qF7/7aiV+soNy+eMVDKlAWgeq BH2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d92si1725808pld.45.2019.01.17.05.06.22; Thu, 17 Jan 2019 05:06:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbfAQNAZ (ORCPT + 99 others); Thu, 17 Jan 2019 08:00:25 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:57549 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727322AbfAQNAZ (ORCPT ); Thu, 17 Jan 2019 08:00:25 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gk7HM-00060w-Pq; Thu, 17 Jan 2019 14:00:16 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1gk7HH-000534-G2; Thu, 17 Jan 2019 14:00:11 +0100 Date: Thu, 17 Jan 2019 14:00:11 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Jitao Shi Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , David Airlie , Matthias Brugger , eddie.huang@mediatek.com, Sascha Hauer , srv_heupstream@mediatek.com, bibby.hsieh@mediatek.com, linux-mediatek@lists.infradead.org, Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Inki Dae , yingjoe.chen@mediatek.com, sj.huang@mediatek.com, Sean Paul , Philipp Zabel , Andy Yan , ck.hu@mediatek.com, Vincent Palatin , Thierry Reding , Ajay Kumar , linux-arm-kernel@lists.infradead.org, Rahul Sharma Subject: Re: [PATCH] pwm: Add MediaTek MT8183 display PWM driver support Message-ID: <20190117130011.lq6wxqpxzq6sc3yy@pengutronix.de> References: <20190116075252.24124-1-jitao.shi@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190116075252.24124-1-jitao.shi@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 03:52:52PM +0800, Jitao Shi wrote: > Use the mtk_pwm_data struction to define different registers > and add MT8183 specific register operations, such as MT8183 > have commit register, needs to enable double buffer > before writing register, and needs to select commit mode > and use PWM_PERIOD/PWM_HIGH_WIDTH. You forgot to add linux-pwm to the recipents. Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |