Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 17 Jan 2019 13:32:02 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, namhyung@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf scripts python: Add Python 3 support to
 check-perf-trace.py
Message-ID: <20190117123202.GC16366@krava>
References: <1547718344-27382-1-git-send-email-s1seetee@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1547718344-27382-1-git-send-email-s1seetee@linux.vnet.ibm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 17, 2019 at 03:15:28PM +0530, Seeteena Thoufeek wrote:
> Support both Python 2 and Python 3 in check-perf-trace.py.
> ``print`` is now a function rather than a statement. This should have
> no functional change.
> 
> Fix indentation issue, replace spaces with tab
> 
> Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>
> Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>

hum, could you please add some info about testing those changes?
(or even some global into 0/.. patch)

this is working for me on python2:

	[root@krava perf]# perf script rec check-perf-trace
	^C
	[root@krava perf]# perf script   -s scripts/python/check-perf-trace.py
	trace_begin

	unhandled events:


	event                                          count

	----------------------------------------  -----------

	raw_syscalls__sys_enter                      3509879


but fails for python3:

	[root@ibm-x3650m4-01-vm-04 perf]# perf script rec check-perf-trace
	^C[ perf record: Woken up 0 times to write data ]
	Warning:
	1 out of order events recorded.
	[ perf record: Captured and wrote 43.132 MB perf.data (490171 samples) ]

	[root@ibm-x3650m4-01-vm-04 perf]# perf script   -s scripts/python/check-perf-trace.py
	Traceback (most recent call last):
	  File "scripts/python/check-perf-trace.py", line 18, in <module>
	    from perf_trace_context import *
	ModuleNotFoundError: No module named 'perf_trace_context'
	Error running python script scripts/python/check-perf-trace.py

I did not test with rpm, just did 'make install' for perf

thanks,
jirka